-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step2: fixes #13781, fixes #13805 #13897
Conversation
let inSpawn = c.inSpawn | ||
if n[0].kind == nkSym and n[0].sym.magic == mSpawn: | ||
c.inSpawn.inc | ||
elif c.inSpawn > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspicious logic. Why not at the end of the of nkCallkinds
handling code like
if n[0].kind == nkSym and n[0].sym.magic == mSpawn:
c.inSpawn.dec
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that spawn can be written in the following way:
spawn myproc(call1(), (let x = call2(); call3(x, 0))
I want c.inSpawn
to be greater than zero only for myproc
call but not for call2
and call3
in example above.
I can't replicate CI test failures. I have tried 3 machines, 2 platforms and 3 compilers. All tests pass. |
Well BSD says: Category: arc Output: |
Ready for review |
Spawn for gc arc fixes