Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step2: fixes #13781, fixes #13805 #13897

Merged
merged 15 commits into from
Apr 16, 2020
Merged

Step2: fixes #13781, fixes #13805 #13897

merged 15 commits into from
Apr 16, 2020

Conversation

cooldome
Copy link
Member

@cooldome cooldome commented Apr 6, 2020

Spawn for gc arc fixes

let inSpawn = c.inSpawn
if n[0].kind == nkSym and n[0].sym.magic == mSpawn:
c.inSpawn.inc
elif c.inSpawn > 0:
Copy link
Member

@Araq Araq Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspicious logic. Why not at the end of the of nkCallkinds handling code like

if n[0].kind == nkSym and n[0].sym.magic == mSpawn:
  c.inSpawn.dec

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that spawn can be written in the following way:

spawn myproc(call1(), (let x = call2(); call3(x, 0))

I want c.inSpawn to be greater than zero only for myproc call but not for call2 and call3 in example above.

@cooldome
Copy link
Member Author

cooldome commented Apr 7, 2020

I can't replicate CI test failures. I have tried 3 machines, 2 platforms and 3 compilers. All tests pass.
Don't know how to progress further

@Araq
Copy link
Member

Araq commented Apr 7, 2020

Well BSD says:

Category: arc
Name: tests/arc/tthread.nim C
Action: run
Result: reExitcodesDiffer
-------- Expected -------
exitcode: 0
--------- Given --------
exitcode: 1

Output:


@cooldome
Copy link
Member Author

Ready for review

@Araq Araq merged commit d3b0132 into devel Apr 16, 2020
@Araq Araq deleted the arc_flowar_step2 branch April 16, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants