Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in tests/js/tconsole #12709

Merged
merged 1 commit into from
Nov 25, 2019
Merged

fix in tests/js/tconsole #12709

merged 1 commit into from
Nov 25, 2019

Conversation

krux02
Copy link
Contributor

@krux02 krux02 commented Nov 22, 2019

whenever I test locally the test suite fails with the following error:

FAIL: tests/js/tconsole.nim JS -d:nodejs
Test "tests/js/tconsole.nim" in category "js"
Failure: reOutputsDiffer
Expected:
Hello, console
1 2 3
1 'hi' 1.1

Gotten:
Hello, console
1 2 3
1 hi 1.1

FAIL: tests/js/tconsole.nim JS -d:nodejs -d:release
Test "tests/js/tconsole.nim" in category "js"
Failure: reOutputsDiffer
Expected:
Hello, console
1 2 3
1 'hi' 1.1

Gotten:
Hello, console
1 2 3
1 hi 1.1

The problem is, console.log is underspecified stuff that does things sometimes differently. Here is a related question about that on stack overflow. I guess it is just a matter of time until nodejs might be updated on the testing servers and CI will also fail there. This removes the test failure.

@krux02
Copy link
Contributor Author

krux02 commented Nov 23, 2019

test failure unrelated.

@narimiran narimiran closed this Nov 24, 2019
@narimiran narimiran reopened this Nov 24, 2019
@Araq Araq merged commit 04614a3 into nim-lang:devel Nov 25, 2019
alehander92 pushed a commit to alehander92/Nim that referenced this pull request Dec 2, 2019
@euantorano
Copy link
Contributor

Note: This fixed #12182, meaning the test could be re-enabled on FreeBSD in #14076!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants