splitPath() behavior synchronized with splitFile() #12481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d behavior in all languages splitPath() docstrings update, tests added for both splitPath() and splitFile()
|
This is a breaking change, so at least it needs a changelog entry and maybe some |
|
@Araq you are right that the change is breaking but also it uniforms the API behaviour making it more intuitive and unambiguous. Let me know please if something specific is further required from my side to accomplish this fix. |
|
Please write a changelog entry and do your patch conditionally like so: |
|
@Araq the respective changelog entry is made and the code is taken into the required condition and optimized. |
|
/cc @timotheecour As I remember him working of this area (path splitting and joining) of the stdlib. |
kiyolee
pushed a commit
to kiyolee/nim
that referenced
this pull request
Nov 7, 2019
* splitPath() behavior synchronized with splitFile() having the expected behavior in all languages splitPath() docstrings update, tests added for both splitPath() and splitFile() * Path splitting refined and described
This was referenced Jul 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior of the paths processing routines is made uniform as expected in all languages (and matches the one in Python), splitPath() docstrings are updated, tests are added for both splitPath() and splitFile().