Typeclass/Variant clarification in Manual #11901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05df931 to
faf6a5d
Compare
faf6a5d to
06c8853
Compare
mratsim
reviewed
Aug 7, 2019
There was a problem hiding this comment.
Sounds good.
If possible, I think the object variant section of the manual should also have sym types, ADTs/Algebraic Data Types, Tagged unions, it can be italicized, see https://github.com/nim-lang/website/pull/157/files.
There are still some confusion from people that know Nim that Nim variants are equivalent to ADTs: https://www.reddit.com/r/rust/comments/clh7pu/rust_reverses_research_ruin/evwnwnc/
207a76c to
4c08413
Compare
narimiran
pushed a commit
that referenced
this pull request
Aug 12, 2019
* [Docs] clarified what type classes do in manual * [Docs] fixed 'dynamism', added to object variant section (cherry picked from commit 9321b33)
narimiran
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [Docs] clarified what type classes do in manual * [Docs] fixed 'dynamism', added to object variant section (cherry picked from commit 9321b33)
narimiran
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [Docs] clarified what type classes do in manual * [Docs] fixed 'dynamism', added to object variant section (cherry picked from commit 9321b33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11798.