regression: rendering of strings has bad syntax highlighting

[timotheecour]

Example

proc fn*() =
  runnableExamples:
    let a = "ok1\nok2\nok3"
    let b = "ok1\nok2 alt\nok3"

nim doc main

Current Output

Expected Output

output with 1.2 was better:

Additional Information

1.5.1 01bca8c
/cc @a-mr if you have any ideas?

[a-mr]

the same bug is in 1.4 and it's a bug in highlite.nim.

I was not able to determine the origin of regression: checking git log showed that no essential change was done in highlite.nim between 1.2 and 1.4. I thought for a moment that it's escape sequences being highlighted with the same color as string literals, but it seems doc/nimdoc.css already had the dedicated color for --escape in 1.2. :-/

Anyway output for 1.2 is not correct because \n is not highlighted.

[timotheecour]

I was not able to determine the origin of regression

git bisect should work (comparing presence of a bad string in the html or css), but maybe in this case we don't need to figure out which commit introduced this change and it can be fixed directly

Anyway output for 1.2 is not correct because \n is not highlighted.

hmm, it's subjective though; should it highlight it? i don't mind if it does but at least shouldn't be highlighted as above

[a-mr]

@timotheecour
git bisect showed that the first "bad" commit is e013ebc.