-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapViewOfFileEx
of winlean.nim
has wrong FFI declaration
#12186
Labels
Comments
Not sure I like this attitute :P |
Sorry, it doesn't meant to offend or insult anyone. But yeah, the sentence is ambiguous and may lead to a wrong interpretation. |
vers10ne
added a commit
to vers10ne/Nim
that referenced
this issue
Sep 15, 2019
`mapViewOfFileEx` of `winlean.nim` has wrong FFI declaration nim-lang#12186 dwNumberOfBytesToMap is assigned DWORD type. but according to official doc it should be SIZE_T. SIZE_T is uint32 on 32-bit target and uint64 on 64-bit target.
vers10ne
added a commit
to vers10ne/Nim
that referenced
this issue
Sep 15, 2019
to see if fixes nim-lang#12186
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this issue
Oct 31, 2019
mratsim
pushed a commit
to status-im/nimbus-eth2
that referenced
this issue
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current
dwNumberOfBytesToMap
is assigned DWORD type. but according to official doc it should beSIZE_T
.SIZE_T
is uint32 on 32-bit target and uint64 on 64-bit target.It has trigger almost heisenbug like bug and very difficult to probe.
I think the fix is easy, so I left it for you to handle it.
The text was updated successfully, but these errors were encountered: