Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int128 Undocumented #11847

Closed
juancarlospaco opened this issue Jul 29, 2019 · 4 comments
Closed

int128 Undocumented #11847

juancarlospaco opened this issue Jul 29, 2019 · 4 comments
Assignees
@krux02
Labels
Documentation Related to documentation content (not generation).

Comments

@juancarlospaco
Copy link
Collaborator

  • int128 is Undocumented.
  • int128 is missing from TheIndex.

Should be nice to have it documented, even as Experimental.
🙂
@alaviss
Copy link
Collaborator

alaviss commented Jul 29, 2019 •
edited
Loading

int128 is a big number library exclusively used by the compiler to process (u)int64 in case statements, so I don't think it's designed for general consumption.

Also, it's not in the stdlib.

@juancarlospaco
Copy link
Collaborator Author

It is exported with a *, and it didnt warning anywhere is internal-only (comment or warning pragma),
I was thinking it was some kind of Experimental feature.

Feel free to close if its internal-only.

@krux02
Copy link
Contributor

krux02 commented Jul 29, 2019 •
edited
Loading

Well, I wrote int128, and I can tell you for sure that it is compiler internal usage only. That is also the reason why it is in compiler/int128. The * for symbol export is required though. Otherwise import int128 in the compiler is a bit pointless. But I can add a documentation comment to int128, if that makes you happy.

@krux02 krux02 self-assigned this Jul 29, 2019
@krux02 krux02 added the Documentation Related to documentation content (not generation). label Jul 29, 2019
@juancarlospaco
Copy link
Collaborator Author

@krux02 Thanks for the work!, code looks good, I didnt know it was internal-only,
I was thinking it was kinda experimental or similar thing to tinker with,
yeah just a line of documentation comment on top of module will do and Close this.
Sorry for the noise.

krux02 added a commit to krux02/Nim that referenced this issue Jul 30, 2019
@krux02
add commint to int128, fixes nim-lang#11847
2a9c85e
@Araq Araq closed this as completed in afbcd1b Aug 7, 2019
narimiran pushed a commit that referenced this issue Aug 12, 2019
@krux02 @narimiran
int128 on firstOrd, lastOrd and lengthOrd (#11701)
b69ab68 
* fixes #11847

(cherry picked from commit afbcd1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krux02 krux02

Labels
Documentation Related to documentation content (not generation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krux02 @juancarlospaco @alaviss