Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve users_build_cache_tree scheduling. #4449

Conversation

corentin-soriano
Copy link
Contributor

@corentin-soriano corentin-soriano commented Nov 7, 2024

Avoid user_build_cache_tree duplicates on each folder creation.
Do not start the same task again if the scheduler is launched several times.

An interesting case where the task caused an outage: multiple user_build_cache_trees per user and 455 tasks were performing the same actions at the same time.

[root@localhost ~]# ps aux | grep background_tasks___user_task.php | wc -l
455

image

Yes, the server has reached 300 of load avg!

Copy link
Owner

@nilsteampassnet nilsteampassnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.
I already experimented such outage but couldn't fixed it.
👍

@corentin-soriano corentin-soriano marked this pull request as ready for review November 8, 2024 09:18
@nilsteampassnet nilsteampassnet merged commit c02e123 into nilsteampassnet:master Nov 8, 2024
1 check passed
@corentin-soriano corentin-soriano deleted the improve_user_build_cache_tree branch November 22, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants