Code review fixes #4412
Merged
Code review fixes #4412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsteampassnet
commented
Oct 11, 2024
includes/config/include.php
Outdated
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| define('TP_VERSION', '3.1.2'); | |||
| define("UPGRADE_MIN_DATE", "1727110744"); | |||
| define('TP_VERSION_MINOR', '134'); | |||
| define('TP_VERSION_MINOR', '6'); | |||
corentin-soriano
suggested changes
Oct 11, 2024
sources/upload.attachments.php
Outdated
Comment on lines
487
to
489
|
|
||
| // Force exit to avoid bypass filters. | ||
| exit; |
There was a problem hiding this comment.
The upload will continue even if a positive is triggered in a filter without this exit.
This will open a security issue.
includes/config/include.php
Outdated
Comment on lines
29
to
31
| define('TP_VERSION', '3.1.2'); | ||
| define("UPGRADE_MIN_DATE", "1727110744"); | ||
| define('TP_VERSION_MINOR', '6'); | ||
| define('TP_VERSION_MINOR', '7'); |
There was a problem hiding this comment.
Did you forget to bump TP_VERSION to 3.1.3?
There was a problem hiding this comment.
In fact I have not yet decided.
We can have this decision once we decide to make 3.1.2 released.
I'm open to discuss it 😉
sources/upload.files.php
Outdated
Comment on lines
371
to
374
| } else { | ||
| // Do we have errors | ||
| echo handleUploadError('Error while moving the uploaded file.'); | ||
| } |
corentin-soriano
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of small fixes during code review