Fix applicative privilege escalation. #4397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, a manager can edit existing user and give him admin role.
$session_user_manager
to int -> to fix issue where managers can't see "users" section (but can access with ?page=users)We can edit like this:
I changed new_user to fit as this to and moved this error before "duplicate login" because it is a good practice.
We redid a series of tests to validate that it is no longer possible to create/modify a user in an illegitimate way.