Fix for broken JSON response when ldap group id is binary #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed placeholder in ldap_groups_roles queries to reflect the non-integer value
|
Had to force push for signing |
|
Thank you |
nilsteampassnet
added a commit
that referenced
this pull request
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed placeholder in ldap_groups_roles queries to reflect the non-integer value
My Problem was, when using Teampass with Active Directory, I didn't get the right amount of Roles through the LDAP Synchronization, with Int I got only 3 roles through the Synchronization, so we had the idea to change the int value to a md5 hash.
In my case it worked and I got all Roles through the Active Directory.
My next problem was, that Teampass mapped some of the Active Directory Roles with some Teampass Roles I imported through the User Synchronization. When I tried to map a Role to another Role and hit Refresh, the change was reverted. After a bit of research I found a similar issue where you posted a fix, most of it was already implemented but a placeholder change in roles.queries.php on line 746 was missing.
Additionally I had to change the placeholder in identify.php on line 1419 from %I to %s because the Roles didn't update on login. Through the change the User got their roles assigned on login and get updated after every Login.