Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(background-sync): clean up open PRs that are deleted on GitHub #218

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

nikku
Copy link
Owner

@nikku nikku commented Nov 18, 2024

Which issue does this PR address?

Pull requests cannot be deleted via API, only internally by GitHub staff. This may lead to PR references to be "dangling". The resolution is to treat all open PRs that could not be fetched as "upstream deleted".

Worst case these PRs will re-appear onto the board on PR activity, or next background sync.

Closes #216

@nikku nikku self-assigned this Nov 18, 2024
Pull requests cannot be deleted via API, only internally by GitHub staff.
This may lead to PR references to be "dangling". The resolution is to
treat all open PRs that could not be fetched as "upstream deleted".

Worst case these PRs will re-appear onto the board on PR activity, or
next background sync.

Closes #216
@nikku nikku merged commit cf9cfa3 into main Nov 18, 2024
4 checks passed
@nikku nikku deleted the fix-orphan-pr branch November 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed pull request is not removed from the board
1 participant