Revert proper

nik9000 · Jan 16, 2025 · b68f1f4 · b68f1f4
1 parent 06d3f4c
commit b68f1f4
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 230 deletions.
diff --git a/docs/reference/esql/functions/kibana/definition/mv_sort.json b/docs/reference/esql/functions/kibana/definition/mv_sort.json
diff --git a/docs/reference/esql/functions/types/mv_sort.asciidoc b/docs/reference/esql/functions/types/mv_sort.asciidoc
diff --git a/...java/org/elasticsearch/xpack/esql/expression/function/AbstractScalarFunctionTestCase.java b/...java/org/elasticsearch/xpack/esql/expression/function/AbstractScalarFunctionTestCase.java
@@ -108,9 +108,15 @@ protected static Iterable<Object[]> parameterSuppliersFromTypedDataWithDefaultCh
     protected static Iterable<Object[]> parameterSuppliersFromTypedDataWithDefaultChecks(
         ExpectedType nullsExpectedType,
         ExpectedEvaluatorToString evaluatorToString,
-        List<TestCaseSupplier> suppliers
+        List<TestCaseSupplier> suppliers,
+        PositionalErrorMessageSupplier positionalErrorMessageSupplier
     ) {
-        return parameterSuppliersFromTypedData(anyNullIsNull(randomizeBytesRefsOffset(suppliers), nullsExpectedType, evaluatorToString));
+        return parameterSuppliersFromTypedData(
+            errorsForCasesWithoutExamples(
+                anyNullIsNull(randomizeBytesRefsOffset(suppliers), nullsExpectedType, evaluatorToString),
+                positionalErrorMessageSupplier
+            )
+        );
     }
 
     public final void testEvaluate() {

diff --git a/...lasticsearch/xpack/esql/expression/function/scalar/multivalue/MvPercentileErrorTests.java b/...lasticsearch/xpack/esql/expression/function/scalar/multivalue/MvPercentileErrorTests.java
diff --git a/...org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvPercentileTests.java b/...org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvPercentileTests.java
@@ -357,7 +357,8 @@ public static Iterable<Object[]> parameters() {
                 ? DataType.NULL
                 : original.expectedType(),
             (nullPosition, nullData, original) -> original,
-            cases
+            cases,
+            (v, p) -> "numeric except unsigned_long"
         );
     }