Release 0.12.2 #4748
Release 0.12.2 #4748
Conversation
sulkaharo
commented
Jul 20, 2019
- Adds X close buttons to all views on the site, to help unstuck iOS users who've added the site to springboard
|
I think this one should have more conversation before merging. The philosophy of the clock views has always been an edge-to-edge fullscreen experience with zero elements that aren't absolutely necessary — these are meant to be displayed on walls and in docks, and are as much decorative as they are functional. And aside from all that, I don't actually see why this button helps in any way — when you're in the fullscreen view and want to get out, you just push the Home button (or swipe up on an iPhone X or later). (This is different from, say, the Profile Editor, where users are typically popping in to change something and then wanting to pop back to the main site — in that case, a back/close button is actually helpful.) |
|
(Also also, I think we could probably clean up the button in the Profile and Reports views while it's in dev, before pushing to release — the size and shape and centering are a little janky, at least in my browsers here.) |
|
Also also also :) The space provided for the close box appears to be nudging the whole set of toolbar icons on the main screen over to the left — these should remain tucked in the far right corner, especially on mobile. |
|
Ah, need to fix the main screen buttons. On iOS 12, the home screen apps do not restart when you “kill” the app and thus you cannot go back to the main view by killing the view. We can add a preference to make the button invisible to users who don’t want the see the button, but preferably in a manner that still allows closing the view. |
|
Edit after I realized what you're doing — you've got the main NS site pinned as an app, yeah? Yes, if you go into a sub-view from there, it'll "stick" and return to the same view on subsequent launches. But you don't need on-screen controls to go back — just swipe left-to-right. |
|
Anyway, can we revert this one for now, maybe work out the reasoning and layout stuff in dev? |