Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carelink dev servers #4007

Closed
wants to merge 3 commits into from
Closed

Carelink dev servers #4007

wants to merge 3 commits into from

Conversation

propke
Copy link

@propke propke commented Oct 19, 2018

hope this is correct to download it from you

@PieterGit
Copy link
Contributor

PieterGit commented Oct 19, 2018

@propke there are several issues with this PR:

  1. you always need to target PR's to the dev branch and not to the master branch
  2. we don't accept new https:// or git:// url's for packages, but only want npm released packages
  3. we should avoid users to add credentials to files that are under version control, because they will be readable to all people

So best, to work with @mddub and @szymjaw to create a documentation or code change for minimed-connect-to-nightscout like @szymjaw started on mddub/minimed-connect-to-nightscout#11

Closing this PR. If you need a nightscout PR to upgrade minimed-connect-to-nightscout feel free to open a new PR.

@PieterGit PieterGit closed this Oct 19, 2018
@PieterGit
Copy link
Contributor

See #4190 for this PR targeted at the dev branch.

@szymjaw
Copy link
Contributor

szymjaw commented Jan 30, 2019 via email

@szymjaw szymjaw deleted the carelink-dev-servers branch May 9, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants