feat: add icon_padding setting #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to reduce the space between the left side of the card and the icon, as wel as the space between the icon and the text, so I added a setting and figure I'd open a PR for it.
The setting takes the padding that should be kept around the icon in pixels. This is then applied to the absolutely positioned icon's
leftproperty, and we adjust the left padding around the content div (which is 72px by default) to be twice the given value plus 24 pixels for the width of the icon itself.Edit: I just realised I didn't include a new built version, let me know if you want me to do that and I'll update the PR.