Add more data to the generated junit results

Add some information that some tools looking to parse the junit results are expecting to be present.
nicrowe00 · Apr 14, 2020 · 9912c2f · 9912c2f
1 parent 33cb5c6
commit 9912c2f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/Turkey.Tests/TestOutputFormatTest.cs b/Turkey.Tests/TestOutputFormatTest.cs
@@ -17,7 +17,7 @@ public async Task EmptyResultsProduceBasicXml()
             var xml = File.ReadAllText(resultsFile.FullName);
 
             var expectedXml = @"<?xml version=""1.0"" encoding=""utf-8""?>
-<testsuite />";
+<testsuite name=""dotnet"" tests=""0"" failures=""0"" errors=""0"" />";
 
             Assert.Equal(expectedXml, xml);
 
@@ -36,7 +36,7 @@ public async Task SingleTestWithPassingResultProducesValidXml()
             var xml = File.ReadAllText(resultsFile.FullName);
 
             var expectedXml = @"<?xml version=""1.0"" encoding=""utf-8""?>
-<testsuite>
+<testsuite name=""dotnet"" tests=""1"" failures=""0"" errors=""0"">
   <testcase name=""foo"" classname=""TestSuite"">
     <system-out></system-out>
     <system-err></system-err>
@@ -62,7 +62,7 @@ public async Task ControlCharactersInTestOutputAreNotPresentInXml()
             var xml = File.ReadAllText(resultsFile.FullName);
 
             var expectedXml = @"<?xml version=""1.0"" encoding=""utf-8""?>
-<testsuite>
+<testsuite name=""dotnet"" tests=""1"" failures=""0"" errors=""0"">
   <testcase name=""foo"" classname=""TestSuite"">
     <system-out>aaa</system-out>
     <system-err>bbb</system-err>

diff --git a/Turkey/TestOutputFormat.cs b/Turkey/TestOutputFormat.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using System.Text.RegularExpressions;
 using System.Threading.Tasks;
 using System.Xml;
@@ -165,6 +166,10 @@ public async override Task AfterRunningAllTestsAsync(TestResults results)
                     writer.WriteStartDocument();
 
                     writer.WriteStartElement("testsuite");
+                    writer.WriteAttributeString("name", "dotnet");
+                    writer.WriteAttributeString("tests", _testCases.Count.ToString());
+                    writer.WriteAttributeString("failures", _testCases.Where(t => t.Failed).Count().ToString());
+                    writer.WriteAttributeString("errors", "0");
 
                     foreach (var testCase in _testCases)
                     {