Remove unnecessary parens on static field get

nicolo-ribaudo · Feb 2, 2024 · badd33d · badd33d
1 parent c74453f
commit badd33d
Show file tree

Hide file tree

Showing 82 changed files with 714 additions and 714 deletions.
diff --git a/packages/babel-helper-create-class-features-plugin/src/fields.ts b/packages/babel-helper-create-class-features-plugin/src/fields.ts
@@ -413,13 +413,15 @@ const privateNameHandlerSpec: Handler<PrivateNameState & Receiver> & Receiver =
           return get;
         }
 
-        return t.sequenceExpression([
-          t.callExpression(file.addHelper("classCheckPrivateStaticAccess"), [
-            receiver,
-            t.cloneNode(classRef),
-          ]),
-          get,
-        ]);
+        const brandCheck = t.callExpression(
+          file.addHelper("classCheckPrivateStaticAccess"),
+          [receiver, t.cloneNode(classRef)],
+        );
+        if (!isMethod) {
+          brandCheck.arguments.push(get);
+          return brandCheck;
+        }
+        return t.sequenceExpression([brandCheck, get]);
       }
 
       if (isMethod) {

diff --git a/...gin-proposal-decorators/test/fixtures/2021-12-accessors--to-es2015/context-name/output.js b/...gin-proposal-decorators/test/fixtures/2021-12-accessors--to-es2015/context-name/output.js
@@ -16,49 +16,49 @@ class Foo {
     babelHelpers.classPrivateMethodInitSpec(this, _a);
   }
   static get a() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _A._);
   }
   static set a(v) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get "b"() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _C._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _C._);
   }
   static set "b"(v) {
     _C._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get ["c"]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _D._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _D._);
   }
   static set ["c"](v) {
     _D._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get 0() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _E._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _E._);
   }
   static set 0(v) {
     _E._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get [1]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _F._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _F._);
   }
   static set [1](v) {
     _F._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get 2n() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _G._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _G._);
   }
   static set 2n(v) {
     _G._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get [3n]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _H._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _H._);
   }
   static set [3n](v) {
     _H._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get [_computedKey]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _I._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _I._);
   }
   static set [_computedKey](v) {
     _I._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
@@ -73,7 +73,7 @@ function _get_a2() {
 }
 (() => {
   [_init_a, _init_a2, _get_a, _set_a, _init_computedKey, _init_computedKey2, _init_computedKey3, _init_computedKey4, _init_computedKey5, _init_computedKey6, _init_computedKey7, _initStatic] = babelHelpers.applyDecs(_Foo, [[dec, 6, "a"], [dec, 6, "a", function () {
-    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _B._);
   }, function (value) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
   }], [dec, 6, "b"], [dec, 6, "c"], [dec, 6, 0], [dec, 6, 1], [dec, 6, 2n], [dec, 6, 3n], [dec, 6, _computedKey]], []);

diff --git a/...n-proposal-decorators/test/fixtures/2021-12-accessors--to-es2015/static-private/output.js b/...n-proposal-decorators/test/fixtures/2021-12-accessors--to-es2015/static-private/output.js
@@ -21,11 +21,11 @@ function _get_b2() {
 }
 (() => {
   [_init_a, _get_a, _set_a, _init_b, _get_b, _set_b, _initStatic] = babelHelpers.applyDecs(_Foo, [[dec, 6, "a", function () {
-    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _A._);
   }, function (value) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
   }], [dec, 6, "b", function () {
-    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _B._);
   }, function (value) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
   }]], []);

diff --git a/...in-proposal-decorators/test/fixtures/2021-12-accessors--to-es2015/static-public/output.js b/...in-proposal-decorators/test/fixtures/2021-12-accessors--to-es2015/static-public/output.js
@@ -2,19 +2,19 @@ var _initStatic, _init_a, _init_b, _init_computedKey, _Foo;
 const dec = () => {};
 class Foo {
   static get a() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _A._);
   }
   static set a(v) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get b() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _B._);
   }
   static set b(v) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get ['c']() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _C._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _C._);
   }
   static set ['c'](v) {
     _C._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);

diff --git a/...ecorators/test/fixtures/2021-12-accessors--to-es2015/undecorated-static-private/output.js b/...ecorators/test/fixtures/2021-12-accessors--to-es2015/undecorated-static-private/output.js
@@ -3,13 +3,13 @@ const dec = () => {};
 class Foo {}
 _Foo = Foo;
 function _get_a() {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _A._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _A._);
 }
 function _set_a(v) {
   _A._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, v);
 }
 function _get_b() {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _B._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _B._);
 }
 function _set_b(v) {
   _B._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, v);

diff --git a/...decorators/test/fixtures/2021-12-accessors--to-es2015/undecorated-static-public/output.js b/...decorators/test/fixtures/2021-12-accessors--to-es2015/undecorated-static-public/output.js
@@ -1,19 +1,19 @@
 const dec = () => {};
 class Foo {
   static get a() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _A._);
   }
   static set a(v) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get b() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _B._);
   }
   static set b(v) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get ['c']() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _C._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _C._);
   }
   static set ['c'](v) {
     _C._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);

diff --git a/...plugin-proposal-decorators/test/fixtures/2021-12-fields--to-es2015/context-name/output.js b/...plugin-proposal-decorators/test/fixtures/2021-12-fields--to-es2015/context-name/output.js
@@ -13,7 +13,7 @@ _computedKey = babelHelpers.toPropertyKey(f());
 class Foo {}
 _Foo = Foo;
 [_init_a, _init_a2, _init_computedKey, _init_computedKey2, _init_computedKey3, _init_computedKey4, _init_computedKey5, _init_computedKey6, _init_computedKey7] = babelHelpers.applyDecs(_Foo, [[dec, 5, "a"], [dec, 5, "a", function () {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _a._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _a._);
 }, function (value) {
   _a._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
 }], [dec, 5, "b"], [dec, 5, "c"], [dec, 5, 0], [dec, 5, 1], [dec, 5, 2n], [dec, 5, 3n], [dec, 5, _computedKey]], []);

diff --git a/...ugin-proposal-decorators/test/fixtures/2021-12-fields--to-es2015/static-private/output.js b/...ugin-proposal-decorators/test/fixtures/2021-12-fields--to-es2015/static-private/output.js
@@ -3,11 +3,11 @@ const dec = () => {};
 class Foo {}
 _Foo = Foo;
 [_init_a, _init_b] = babelHelpers.applyDecs(_Foo, [[dec, 5, "a", function () {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _a._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _a._);
 }, function (value) {
   _a._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
 }], [dec, 5, "b", function () {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _b._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _b._);
 }, function (value) {
   _b._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
 }]], []);

diff --git a/...gin-proposal-decorators/test/fixtures/2021-12-methods--to-es2015/static-private/output.js b/...gin-proposal-decorators/test/fixtures/2021-12-methods--to-es2015/static-private/output.js
@@ -2,7 +2,7 @@ var _initStatic, _call_a, _Foo;
 const dec = () => {};
 class Foo {
   static callA() {
-    return (babelHelpers.classCheckPrivateStaticAccess(this, Foo), _a._).call(this);
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _a._).call(this);
   }
 }
 _Foo = Foo;

diff --git a/...gin-proposal-decorators/test/fixtures/2022-03-accessors--to-es2015/context-name/output.js b/...gin-proposal-decorators/test/fixtures/2022-03-accessors--to-es2015/context-name/output.js
@@ -16,49 +16,49 @@ class Foo {
     babelHelpers.classPrivateMethodInitSpec(this, _a);
   }
   static get a() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _A._);
   }
   static set a(v) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get "b"() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _C._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _C._);
   }
   static set "b"(v) {
     _C._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get ["c"]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _D._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _D._);
   }
   static set ["c"](v) {
     _D._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get 0() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _E._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _E._);
   }
   static set 0(v) {
     _E._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get [1]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _F._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _F._);
   }
   static set [1](v) {
     _F._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get 2n() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _G._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _G._);
   }
   static set 2n(v) {
     _G._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get [3n]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _H._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _H._);
   }
   static set [3n](v) {
     _H._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get [_computedKey]() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _I._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _I._);
   }
   static set [_computedKey](v) {
     _I._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
@@ -73,7 +73,7 @@ function _get_a2() {
 }
 (() => {
   [_init_a, _init_a2, _get_a, _set_a, _init_computedKey, _init_computedKey2, _init_computedKey3, _init_computedKey4, _init_computedKey5, _init_computedKey6, _init_computedKey7, _initStatic] = babelHelpers.applyDecs2203R(_Foo, [[dec, 6, "a"], [dec, 6, "a", function () {
-    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _B._);
   }, function (value) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
   }], [dec, 6, "b"], [dec, 6, "c"], [dec, 6, 0], [dec, 6, 1], [dec, 6, 2n], [dec, 6, 3n], [dec, 6, _computedKey]], []).e;

diff --git a/...n-proposal-decorators/test/fixtures/2022-03-accessors--to-es2015/static-private/output.js b/...n-proposal-decorators/test/fixtures/2022-03-accessors--to-es2015/static-private/output.js
@@ -21,11 +21,11 @@ function _get_b2() {
 }
 (() => {
   [_init_a, _get_a, _set_a, _init_b, _get_b, _set_b, _initStatic] = babelHelpers.applyDecs2203R(_Foo, [[dec, 6, "a", function () {
-    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _A._);
   }, function (value) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
   }], [dec, 6, "b", function () {
-    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _B._);
   }, function (value) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
   }]], []).e;

diff --git a/...in-proposal-decorators/test/fixtures/2022-03-accessors--to-es2015/static-public/output.js b/...in-proposal-decorators/test/fixtures/2022-03-accessors--to-es2015/static-public/output.js
@@ -2,19 +2,19 @@ var _initStatic, _init_a, _init_b, _init_computedKey, _Foo;
 const dec = () => {};
 class Foo {
   static get a() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _A._);
   }
   static set a(v) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get b() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _B._);
   }
   static set b(v) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get ['c']() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _C._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _C._);
   }
   static set ['c'](v) {
     _C._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);

diff --git a/...ecorators/test/fixtures/2022-03-accessors--to-es2015/undecorated-static-private/output.js b/...ecorators/test/fixtures/2022-03-accessors--to-es2015/undecorated-static-private/output.js
@@ -3,13 +3,13 @@ const dec = () => {};
 class Foo {}
 _Foo = Foo;
 function _get_a() {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _A._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _A._);
 }
 function _set_a(v) {
   _A._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, v);
 }
 function _get_b() {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _B._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _B._);
 }
 function _set_b(v) {
   _B._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, v);

diff --git a/...decorators/test/fixtures/2022-03-accessors--to-es2015/undecorated-static-public/output.js b/...decorators/test/fixtures/2022-03-accessors--to-es2015/undecorated-static-public/output.js
@@ -1,19 +1,19 @@
 const dec = () => {};
 class Foo {
   static get a() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _A._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _A._);
   }
   static set a(v) {
     _A._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get b() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _B._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _B._);
   }
   static set b(v) {
     _B._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);
   }
   static get ['c']() {
-    return babelHelpers.classCheckPrivateStaticAccess(this, Foo), _C._;
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _C._);
   }
   static set ['c'](v) {
     _C._ = babelHelpers.classCheckPrivateStaticAccess(this, Foo, v);

diff --git a/...plugin-proposal-decorators/test/fixtures/2022-03-fields--to-es2015/context-name/output.js b/...plugin-proposal-decorators/test/fixtures/2022-03-fields--to-es2015/context-name/output.js
@@ -13,7 +13,7 @@ _computedKey = babelHelpers.toPropertyKey(f());
 class Foo {}
 _Foo = Foo;
 [_init_a, _init_a2, _init_computedKey, _init_computedKey2, _init_computedKey3, _init_computedKey4, _init_computedKey5, _init_computedKey6, _init_computedKey7] = babelHelpers.applyDecs2203R(_Foo, [[dec, 5, "a"], [dec, 5, "a", function () {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _a._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _a._);
 }, function (value) {
   _a._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
 }], [dec, 5, "b"], [dec, 5, "c"], [dec, 5, 0], [dec, 5, 1], [dec, 5, 2n], [dec, 5, 3n], [dec, 5, _computedKey]], []).e;

diff --git a/...ugin-proposal-decorators/test/fixtures/2022-03-fields--to-es2015/static-private/output.js b/...ugin-proposal-decorators/test/fixtures/2022-03-fields--to-es2015/static-private/output.js
@@ -3,11 +3,11 @@ const dec = () => {};
 class Foo {}
 _Foo = Foo;
 [_init_a, _init_b] = babelHelpers.applyDecs2203R(_Foo, [[dec, 5, "a", function () {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _a._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _a._);
 }, function (value) {
   _a._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
 }], [dec, 5, "b", function () {
-  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo), _b._;
+  return babelHelpers.classCheckPrivateStaticAccess(this, _Foo, _b._);
 }, function (value) {
   _b._ = babelHelpers.classCheckPrivateStaticAccess(this, _Foo, value);
 }]], []).e;

diff --git a/...gin-proposal-decorators/test/fixtures/2022-03-methods--to-es2015/static-private/output.js b/...gin-proposal-decorators/test/fixtures/2022-03-methods--to-es2015/static-private/output.js
@@ -2,7 +2,7 @@ var _initStatic, _call_a, _Foo;
 const dec = () => {};
 class Foo {
   static callA() {
-    return (babelHelpers.classCheckPrivateStaticAccess(this, Foo), _a._).call(this);
+    return babelHelpers.classCheckPrivateStaticAccess(this, Foo, _a._).call(this);
   }
 }
 _Foo = Foo;