Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): release on tag 👷 #13

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Conversation

meysam81
Copy link
Contributor

@meysam81 meysam81 commented Aug 10, 2023

You can see the ultimate result in the screenshots below. However, this will remove your ability to release on the marketplace. But the upside is that all you have to do is to push a tag starting with v, and everything else is taken care of.

image

Screenshot from 2023-08-10 19-06-53

Screenshot from 2023-08-10 19-08-20

@nicolaiunrein
Copy link
Owner

I struggle to see the real benefits from publishing the action to the marketplace. The only reason I could think of is discoverability. But I mostly copy/paste/alter workflows from well maintained high quality crates which has always been enough for my needs and I have never really looked for actions on the marketplace. Why would we loose the ability to publish to the marketplace if we decided to merge your PR?

@meysam81
Copy link
Contributor Author

You wouldn't "lose" it in the literal sense of the word, but rather it won't be published to the marketplace if you don't release it from GitHub Release page. The only benefit there is when publishing to marketplace is better reach and recognition, but it is still usable if someone has a step uses: nicolaiunrein/cargo-get in their workflows (example, example2).

It is however able to do a new GitHub Release on every push of the tags starting with v.

@nicolaiunrein
Copy link
Owner

nicolaiunrein commented Aug 14, 2023

I am still uncertain what to do. here it says that repos for actions on the marketplace are not allowed to have any workflow files. Do you think this van be solved by moving the action stuff to a separate repo?

@meysam81
Copy link
Contributor Author

"GitHub Actions cannot have any workflow files" has never stopped me publishing to the marketplace before: example

@nicolaiunrein nicolaiunrein merged commit 9706542 into nicolaiunrein:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants