Skip to content

Commit

Permalink
Pipeline Context Variables - Fix Validation Tests
Browse files Browse the repository at this point in the history
The Pipeline(Run) context variables validation tests have errors
in the naming - mistakenly saying that they test Task(Run) context
variables.

In this change, we fix the names of the tests.
  • Loading branch information
jerop authored and tekton-robot committed Mar 17, 2022
1 parent 6738db7 commit 6ae78e5
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions pkg/apis/pipeline/v1beta1/pipeline_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2262,7 +2262,7 @@ func TestContextValid(t *testing.T) {
name string
tasks []PipelineTask
}{{
name: "valid string context variable for task name",
name: "valid string context variable for Pipeline name",
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Expand All @@ -2271,7 +2271,7 @@ func TestContextValid(t *testing.T) {
}},
}},
}, {
name: "valid string context variable for taskrun name",
name: "valid string context variable for PipelineRun name",
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Expand All @@ -2280,7 +2280,7 @@ func TestContextValid(t *testing.T) {
}},
}},
}, {
name: "valid string context variable for taskRun namespace",
name: "valid string context variable for PipelineRun namespace",
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Expand All @@ -2289,7 +2289,7 @@ func TestContextValid(t *testing.T) {
}},
}},
}, {
name: "valid string context variable for taskRun uid",
name: "valid string context variable for PipelineRun uid",
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Expand All @@ -2298,7 +2298,7 @@ func TestContextValid(t *testing.T) {
}},
}},
}, {
name: "valid array context variables for task and taskRun names",
name: "valid array context variables for Pipeline and PipelineRun names",
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Expand Down

0 comments on commit 6ae78e5

Please sign in to comment.