Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race and optimize performance #183

Merged
merged 7 commits into from
Jun 5, 2019
Merged

Fix data race and optimize performance #183

merged 7 commits into from
Jun 5, 2019

Conversation

nicksnyder
Copy link
Owner

@nicksnyder nicksnyder commented Jun 5, 2019

fixes #181
helps #182

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #183 into master will increase coverage by 0.57%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #183      +/-   ##
=========================================
+ Coverage   82.33%   82.9%   +0.57%     
=========================================
  Files          14      14              
  Lines        1285    1293       +8     
=========================================
+ Hits         1058    1072      +14     
+ Misses        161     158       -3     
+ Partials       66      63       -3
Impacted Files Coverage Δ
i18n/message_template.go 92.85% <100%> (+17.85%) ⬆️
internal/template.go 90.47% <90.47%> (+12.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f9eac...2b7f330. Read the comment docs.

@nicksnyder nicksnyder marked this pull request as ready for review June 5, 2019 20:23
@nicksnyder nicksnyder merged commit e0f0d41 into master Jun 5, 2019
@nicksnyder nicksnyder deleted the raceperf branch June 5, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in Template.Parse
1 participant