Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 only #176

Merged
merged 8 commits into from
May 19, 2019
Merged

v2 only #176

merged 8 commits into from
May 19, 2019

Conversation

nicksnyder
Copy link
Owner

fixes #172

fixes #172
@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #176 into master will increase coverage by 10.27%.
The diff coverage is 72.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #176       +/-   ##
===========================================
+ Coverage   72.06%   82.33%   +10.27%     
===========================================
  Files          28       14       -14     
  Lines        2416     1285     -1131     
===========================================
- Hits         1741     1058      -683     
+ Misses        580      161      -419     
+ Partials       95       66       -29
Impacted Files Coverage Δ
i18n/parse.go 73.11% <ø> (ø)
internal/plural/rule_gen.go 100% <ø> (ø)
internal/plural/operands.go 67.64% <ø> (ø)
internal/plural/rule.go 100% <ø> (ø)
i18n/message.go 87.71% <ø> (ø)
i18n/bundle.go 59.61% <ø> (ø)
internal/template.go 77.77% <ø> (ø)
internal/plural/rules.go 100% <ø> (ø)
goi18n/marshal.go 80.55% <ø> (ø)
i18n/message_template.go 75% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6ee90...56cc8dd. Read the comment docs.

@nicksnyder nicksnyder merged commit be3966f into master May 19, 2019
@nicksnyder nicksnyder deleted the v2only branch May 19, 2019 17:46
This was referenced Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove v1 from master and push it to go1 branch
2 participants