Skip to content

Commit

Permalink
SKA: Relocate new response-ops packages (elastic#211241)
Browse files Browse the repository at this point in the history
## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 3 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/response-ops-alerts-apis` |
`src/platform/packages/shared/response-ops/alerts-apis` |
| `@kbn/response-ops-alerts-fields-browser` |
`src/platform/packages/shared/response-ops/alerts-fields-browser` |
| `@kbn/response-ops-alerts-table` |
`src/platform/packages/shared/response-ops/alerts-table` |


<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./src/platform/packages/shared/response-ops/alerts-apis/jest.config.js
./src/platform/packages/shared/response-ops/alerts-fields-browser/jest.config.js
./src/platform/packages/shared/response-ops/alerts-table/jest.config.js
./tsconfig.base.json
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
src/platform/packages/shared/response-ops/alerts-apis/jest.config.js:12
src/platform/packages/shared/response-ops/alerts-apis/tsconfig.json:2
src/platform/packages/shared/response-ops/alerts-fields-browser/jest.config.js:12
src/platform/packages/shared/response-ops/alerts-fields-browser/tsconfig.json:2
src/platform/packages/shared/response-ops/alerts-table/jest.config.js:12
src/platform/packages/shared/response-ops/alerts-table/tsconfig.json:2
```

</details>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Umberto Pepato <umbopepato@users.noreply.github.com>
  • Loading branch information
3 people authored Feb 17, 2025
1 parent c14d52a commit e527f2b
Show file tree
Hide file tree
Showing 171 changed files with 33 additions and 27 deletions.
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,6 @@ packages/kbn-validate-next-docs-cli @elastic/kibana-operations
packages/kbn-web-worker-stub @elastic/kibana-operations
packages/kbn-whereis-pkg-cli @elastic/kibana-operations
packages/kbn-yarn-lock-validator @elastic/kibana-operations
packages/response-ops/alerts_apis @elastic/response-ops
packages/response-ops/alerts_fields_browser @elastic/response-ops
packages/response-ops/alerts_table @elastic/response-ops
packages/serverless/storybook/config @elastic/appex-sharedux
src/core @elastic/kibana-core
src/core/packages/analytics/browser @elastic/kibana-core
Expand Down Expand Up @@ -562,6 +559,9 @@ src/platform/packages/shared/react/kibana_context/root @elastic/appex-sharedux
src/platform/packages/shared/react/kibana_context/styled @elastic/appex-sharedux
src/platform/packages/shared/react/kibana_context/theme @elastic/appex-sharedux
src/platform/packages/shared/react/kibana_mount @elastic/appex-sharedux
src/platform/packages/shared/response-ops/alerts-apis @elastic/response-ops
src/platform/packages/shared/response-ops/alerts-fields-browser @elastic/response-ops
src/platform/packages/shared/response-ops/alerts-table @elastic/response-ops
src/platform/packages/shared/response-ops/rule_form @elastic/response-ops
src/platform/packages/shared/response-ops/rule_params @elastic/response-ops
src/platform/packages/shared/serverless/settings/observability_project @elastic/appex-sharedux @elastic/kibana-management @elastic/obs-ux-management-team
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -761,9 +761,9 @@
"@kbn/resizable-layout": "link:src/platform/packages/shared/kbn-resizable-layout",
"@kbn/resizable-layout-examples-plugin": "link:examples/resizable_layout_examples",
"@kbn/resolver-test-plugin": "link:x-pack/test/plugin_functional/plugins/resolver_test",
"@kbn/response-ops-alerts-apis": "link:packages/response-ops/alerts_apis",
"@kbn/response-ops-alerts-fields-browser": "link:packages/response-ops/alerts_fields_browser",
"@kbn/response-ops-alerts-table": "link:packages/response-ops/alerts_table",
"@kbn/response-ops-alerts-apis": "link:src/platform/packages/shared/response-ops/alerts-apis",
"@kbn/response-ops-alerts-fields-browser": "link:src/platform/packages/shared/response-ops/alerts-fields-browser",
"@kbn/response-ops-alerts-table": "link:src/platform/packages/shared/response-ops/alerts-table",
"@kbn/response-ops-rule-form": "link:src/platform/packages/shared/response-ops/rule_form",
"@kbn/response-ops-rule-params": "link:src/platform/packages/shared/response-ops/rule_params",
"@kbn/response-stream-plugin": "link:examples/response_stream",
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@

module.exports = {
preset: '@kbn/test',
rootDir: '../../..',
roots: ['<rootDir>/packages/response-ops/alerts_apis'],
setupFilesAfterEnv: ['<rootDir>/packages/response-ops/alerts_apis/setup_tests.ts'],
rootDir: '../../../../../..',
roots: ['<rootDir>/src/platform/packages/shared/response-ops/alerts-apis'],
setupFilesAfterEnv: [
'<rootDir>/src/platform/packages/shared/response-ops/alerts-apis/setup_tests.ts',
],
};
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../tsconfig.base.json",
"extends": "../../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
"types": [
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@

module.exports = {
preset: '@kbn/test',
rootDir: '../../..',
roots: ['<rootDir>/packages/response-ops/alerts_fields_browser'],
setupFilesAfterEnv: ['<rootDir>/packages/response-ops/alerts_fields_browser/setup_tests.ts'],
rootDir: '../../../../../..',
roots: ['<rootDir>/src/platform/packages/shared/response-ops/alerts-fields-browser'],
setupFilesAfterEnv: [
'<rootDir>/src/platform/packages/shared/response-ops/alerts-fields-browser/setup_tests.ts',
],
};
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../tsconfig.base.json",
"extends": "../../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
"types": [
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@

module.exports = {
preset: '@kbn/test',
rootDir: '../../..',
roots: ['<rootDir>/packages/response-ops/alerts_table'],
setupFilesAfterEnv: ['<rootDir>/packages/response-ops/alerts_table/setup_tests.ts'],
rootDir: '../../../../../..',
roots: ['<rootDir>/src/platform/packages/shared/response-ops/alerts-table'],
setupFilesAfterEnv: [
'<rootDir>/src/platform/packages/shared/response-ops/alerts-table/setup_tests.ts',
],
};
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../tsconfig.base.json",
"extends": "../../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
"types": [
Expand Down
File renamed without changes.
12 changes: 6 additions & 6 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1504,12 +1504,12 @@
"@kbn/resizable-layout-examples-plugin/*": ["examples/resizable_layout_examples/*"],
"@kbn/resolver-test-plugin": ["x-pack/test/plugin_functional/plugins/resolver_test"],
"@kbn/resolver-test-plugin/*": ["x-pack/test/plugin_functional/plugins/resolver_test/*"],
"@kbn/response-ops-alerts-apis": ["packages/response-ops/alerts_apis"],
"@kbn/response-ops-alerts-apis/*": ["packages/response-ops/alerts_apis/*"],
"@kbn/response-ops-alerts-fields-browser": ["packages/response-ops/alerts_fields_browser"],
"@kbn/response-ops-alerts-fields-browser/*": ["packages/response-ops/alerts_fields_browser/*"],
"@kbn/response-ops-alerts-table": ["packages/response-ops/alerts_table"],
"@kbn/response-ops-alerts-table/*": ["packages/response-ops/alerts_table/*"],
"@kbn/response-ops-alerts-apis": ["src/platform/packages/shared/response-ops/alerts-apis"],
"@kbn/response-ops-alerts-apis/*": ["src/platform/packages/shared/response-ops/alerts-apis/*"],
"@kbn/response-ops-alerts-fields-browser": ["src/platform/packages/shared/response-ops/alerts-fields-browser"],
"@kbn/response-ops-alerts-fields-browser/*": ["src/platform/packages/shared/response-ops/alerts-fields-browser/*"],
"@kbn/response-ops-alerts-table": ["src/platform/packages/shared/response-ops/alerts-table"],
"@kbn/response-ops-alerts-table/*": ["src/platform/packages/shared/response-ops/alerts-table/*"],
"@kbn/response-ops-rule-form": ["src/platform/packages/shared/response-ops/rule_form"],
"@kbn/response-ops-rule-form/*": ["src/platform/packages/shared/response-ops/rule_form/*"],
"@kbn/response-ops-rule-params": ["src/platform/packages/shared/response-ops/rule_params"],
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6877,15 +6877,15 @@
version "0.0.0"
uid ""

"@kbn/response-ops-alerts-apis@link:packages/response-ops/alerts_apis":
"@kbn/response-ops-alerts-apis@link:src/platform/packages/shared/response-ops/alerts-apis":
version "0.0.0"
uid ""

"@kbn/response-ops-alerts-fields-browser@link:packages/response-ops/alerts_fields_browser":
"@kbn/response-ops-alerts-fields-browser@link:src/platform/packages/shared/response-ops/alerts-fields-browser":
version "0.0.0"
uid ""

"@kbn/response-ops-alerts-table@link:packages/response-ops/alerts_table":
"@kbn/response-ops-alerts-table@link:src/platform/packages/shared/response-ops/alerts-table":
version "0.0.0"
uid ""

Expand Down

0 comments on commit e527f2b

Please sign in to comment.