Skip to content

Commit

Permalink
SKA: Relocate core-test-helpers (elastic#212029)
Browse files Browse the repository at this point in the history
## Summary

These where the only packages under `src/dev/packages`.
The goal long term is to refactor the code under `src/dev` and to
migrate it to one (or multiple) packages.
Thus, we're moving them to `src/core/test-helpers/`, which already
exists and contains a bunch of test-helpers.

#### 2 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/core-test-helpers-kbn-server` |
`src/core/test-helpers/kbn-server` |
| `@kbn/core-test-helpers-model-versions` |
`src/core/test-helpers/model-versions` |


<details >
<summary>Updated references</summary>

```
./.github/codeql/codeql-config.yml
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/core/system/tsconfig.type_check.json
./src/core/test-helpers/kbn-server/jest.config.js
./src/core/test-helpers/model-versions/jest.config.js
./src/dev/tsconfig.type_check.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./src/plugins/kibana_usage_collection/tsconfig.type_check.json
./src/plugins/usage_collection/tsconfig.type_check.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/platform/plugins/shared/fleet/tsconfig.type_check.json
./x-pack/platform/plugins/shared/spaces/tsconfig.type_check.json
./x-pack/plugins/actions/tsconfig.type_check.json
./x-pack/plugins/alerting/tsconfig.type_check.json
./x-pack/plugins/task_manager/tsconfig.type_check.json
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
src/core/test-helpers/kbn-server/jest.config.js:12
src/core/test-helpers/kbn-server/tsconfig.json:2
src/core/test-helpers/model-versions/jest.config.js:12
src/core/test-helpers/model-versions/tsconfig.json:2
```

</details>
  • Loading branch information
gsoldevila authored Feb 21, 2025
1 parent 705df21 commit cff1747
Show file tree
Hide file tree
Showing 28 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,8 @@ src/core/packages/user-profile/server-mocks @elastic/kibana-core
src/core/packages/user-settings/server @elastic/kibana-security
src/core/packages/user-settings/server-internal @elastic/kibana-security
src/core/packages/user-settings/server-mocks @elastic/kibana-security
src/dev/packages/core-test-helpers-kbn-server @elastic/kibana-core
src/dev/packages/core-test-helpers-model-versions @elastic/kibana-core
src/core/test-helpers/kbn-server @elastic/kibana-core
src/core/test-helpers/model-versions @elastic/kibana-core
src/platform/packages/private/analytics/utils/analytics_collection_utils @elastic/kibana-core
src/platform/packages/private/default-nav/analytics @elastic/kibana-data-discovery @elastic/kibana-presentation @elastic/kibana-visualizations
src/platform/packages/private/default-nav/devtools @elastic/kibana-management
Expand Down
2 changes: 1 addition & 1 deletion .github/codeql/codeql-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ paths-ignore:
- legacy_rfcs
- oas_docs
- packages/*/scripts
- src/dev/packages/core-test-helpers-kbn-server
- src/core/test-helpers/kbn-server
- packages/kbn-ambient-*-types
- packages/kbn-apm-synthtrace
- packages/kbn-axe-config
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1426,8 +1426,8 @@
"@kbn/core-saved-objects-migration-server-mocks": "link:src/core/packages/saved-objects/migration-server-mocks",
"@kbn/core-saved-objects-server-mocks": "link:src/core/packages/saved-objects/server-mocks",
"@kbn/core-status-server-mocks": "link:src/core/packages/status/server-mocks",
"@kbn/core-test-helpers-kbn-server": "link:src/dev/packages/core-test-helpers-kbn-server",
"@kbn/core-test-helpers-model-versions": "link:src/dev/packages/core-test-helpers-model-versions",
"@kbn/core-test-helpers-kbn-server": "link:src/core/test-helpers/kbn-server",
"@kbn/core-test-helpers-model-versions": "link:src/core/test-helpers/model-versions",
"@kbn/core-theme-browser-mocks": "link:src/core/packages/theme/browser-mocks",
"@kbn/core-ui-settings-browser-mocks": "link:src/core/packages/ui-settings/browser-mocks",
"@kbn/core-ui-settings-server-mocks": "link:src/core/packages/ui-settings/server-mocks",
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
module.exports = {
preset: '@kbn/test/jest_node',
rootDir: '../../../..',
roots: ['<rootDir>/src/dev/packages/core-test-helpers-kbn-server'],
roots: ['<rootDir>/src/core/test-helpers/kbn-server'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
module.exports = {
preset: '@kbn/test/jest_node',
rootDir: '../../../..',
roots: ['<rootDir>/src/dev/packages/core-test-helpers-model-versions'],
roots: ['<rootDir>/src/core/test-helpers/model-versions'],
};
8 changes: 4 additions & 4 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -626,10 +626,10 @@
"@kbn/core-test-helpers-deprecations-getters/*": ["src/core/packages/test-helpers/deprecations-getters/*"],
"@kbn/core-test-helpers-http-setup-browser": ["src/core/packages/test-helpers/http-setup-browser"],
"@kbn/core-test-helpers-http-setup-browser/*": ["src/core/packages/test-helpers/http-setup-browser/*"],
"@kbn/core-test-helpers-kbn-server": ["src/dev/packages/core-test-helpers-kbn-server"],
"@kbn/core-test-helpers-kbn-server/*": ["src/dev/packages/core-test-helpers-kbn-server/*"],
"@kbn/core-test-helpers-model-versions": ["src/dev/packages/core-test-helpers-model-versions"],
"@kbn/core-test-helpers-model-versions/*": ["src/dev/packages/core-test-helpers-model-versions/*"],
"@kbn/core-test-helpers-kbn-server": ["src/core/test-helpers/kbn-server"],
"@kbn/core-test-helpers-kbn-server/*": ["src/core/test-helpers/kbn-server/*"],
"@kbn/core-test-helpers-model-versions": ["src/core/test-helpers/model-versions"],
"@kbn/core-test-helpers-model-versions/*": ["src/core/test-helpers/model-versions/*"],
"@kbn/core-test-helpers-so-type-serializer": ["src/core/packages/test-helpers/so-type-serializer"],
"@kbn/core-test-helpers-so-type-serializer/*": ["src/core/packages/test-helpers/so-type-serializer/*"],
"@kbn/core-test-helpers-test-utils": ["src/core/packages/test-helpers/test-utils"],
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5117,11 +5117,11 @@
version "0.0.0"
uid ""

"@kbn/core-test-helpers-kbn-server@link:src/dev/packages/core-test-helpers-kbn-server":
"@kbn/core-test-helpers-kbn-server@link:src/core/test-helpers/kbn-server":
version "0.0.0"
uid ""

"@kbn/core-test-helpers-model-versions@link:src/dev/packages/core-test-helpers-model-versions":
"@kbn/core-test-helpers-model-versions@link:src/core/test-helpers/model-versions":
version "0.0.0"
uid ""

Expand Down

0 comments on commit cff1747

Please sign in to comment.