Skip to content

Commit

Permalink
SKA: Fix kebab-case issues in obs-ai-assistant packages (elastic#211346)
Browse files Browse the repository at this point in the history
## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 2 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/observability-ai-common` |
`x-pack/solutions/observability/packages/observability-ai/observability-ai-common`
|
| `@kbn/observability-ai-server` |
`x-pack/solutions/observability/packages/observability-ai/observability-ai-server`
|


<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./tsconfig.base.json
./x-pack/solutions/observability/packages/observability-ai/observability-ai-common/jest.config.js
./x-pack/solutions/observability/packages/observability-ai/observability-ai-server/jest.config.js
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/solutions/observability/packages/observability-ai/observability-ai-common/jest.config.js:10
x-pack/solutions/observability/packages/observability-ai/observability-ai-common/tsconfig.json:2
x-pack/solutions/observability/packages/observability-ai/observability-ai-server/jest.config.js:10
x-pack/solutions/observability/packages/observability-ai/observability-ai-server/tsconfig.json:2
```

</details>
  • Loading branch information
gsoldevila authored Feb 16, 2025
1 parent e9206f9 commit 299a91c
Show file tree
Hide file tree
Showing 46 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -925,8 +925,8 @@ x-pack/solutions/observability/packages/kbn-custom-integrations @elastic/obs-ux-
x-pack/solutions/observability/packages/kbn-investigation-shared @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/kbn-scout-oblt @elastic/appex-qa
x-pack/solutions/observability/packages/kbn-streams-schema @elastic/streams-program-team
x-pack/solutions/observability/packages/observability_ai/observability_ai_common @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/observability_ai/observability_ai_server @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/observability-ai/observability-ai-common @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/observability-ai/observability-ai-server @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/synthetics_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/utils-browser @elastic/observability-ui
x-pack/solutions/observability/packages/utils-common @elastic/observability-ui
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -699,8 +699,8 @@
"@kbn/observability-ai-assistant-app-plugin": "link:x-pack/solutions/observability/plugins/observability_ai_assistant_app",
"@kbn/observability-ai-assistant-management-plugin": "link:x-pack/solutions/observability/plugins/observability_ai_assistant_management",
"@kbn/observability-ai-assistant-plugin": "link:x-pack/platform/plugins/shared/observability_ai_assistant",
"@kbn/observability-ai-common": "link:x-pack/solutions/observability/packages/observability_ai/observability_ai_common",
"@kbn/observability-ai-server": "link:x-pack/solutions/observability/packages/observability_ai/observability_ai_server",
"@kbn/observability-ai-common": "link:x-pack/solutions/observability/packages/observability-ai/observability-ai-common",
"@kbn/observability-ai-server": "link:x-pack/solutions/observability/packages/observability-ai/observability-ai-server",
"@kbn/observability-alert-details": "link:x-pack/solutions/observability/packages/alert_details",
"@kbn/observability-alerting-test-data": "link:x-pack/solutions/observability/packages/alerting_test_data",
"@kbn/observability-fixtures-plugin": "link:x-pack/test/cases_api_integration/common/plugins/observability",
Expand Down
8 changes: 4 additions & 4 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1340,10 +1340,10 @@
"@kbn/observability-ai-assistant-management-plugin/*": ["x-pack/solutions/observability/plugins/observability_ai_assistant_management/*"],
"@kbn/observability-ai-assistant-plugin": ["x-pack/platform/plugins/shared/observability_ai_assistant"],
"@kbn/observability-ai-assistant-plugin/*": ["x-pack/platform/plugins/shared/observability_ai_assistant/*"],
"@kbn/observability-ai-common": ["x-pack/solutions/observability/packages/observability_ai/observability_ai_common"],
"@kbn/observability-ai-common/*": ["x-pack/solutions/observability/packages/observability_ai/observability_ai_common/*"],
"@kbn/observability-ai-server": ["x-pack/solutions/observability/packages/observability_ai/observability_ai_server"],
"@kbn/observability-ai-server/*": ["x-pack/solutions/observability/packages/observability_ai/observability_ai_server/*"],
"@kbn/observability-ai-common": ["x-pack/solutions/observability/packages/observability-ai/observability-ai-common"],
"@kbn/observability-ai-common/*": ["x-pack/solutions/observability/packages/observability-ai/observability-ai-common/*"],
"@kbn/observability-ai-server": ["x-pack/solutions/observability/packages/observability-ai/observability-ai-server"],
"@kbn/observability-ai-server/*": ["x-pack/solutions/observability/packages/observability-ai/observability-ai-server/*"],
"@kbn/observability-alert-details": ["x-pack/solutions/observability/packages/alert_details"],
"@kbn/observability-alert-details/*": ["x-pack/solutions/observability/packages/alert_details/*"],
"@kbn/observability-alerting-test-data": ["x-pack/solutions/observability/packages/alerting_test_data"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = {
preset: '@kbn/test',
rootDir: '../../../../../..',
roots: [
'<rootDir>/x-pack/solutions/observability/packages/observability_ai/observability_ai_common',
'<rootDir>/x-pack/solutions/observability/packages/observability_ai/observability_ai_server',
'<rootDir>/x-pack/solutions/observability/packages/observability-ai/observability-ai-common',
'<rootDir>/x-pack/solutions/observability/packages/observability-ai/observability-ai-server',
],
};
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ module.exports = {
preset: '@kbn/test',
rootDir: '../../../../../..',
roots: [
'<rootDir>/x-pack/solutions/observability/packages/observability_ai/observability_ai_server',
'<rootDir>/x-pack/solutions/observability/packages/observability-ai/observability-ai-server',
],
};
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6549,11 +6549,11 @@
version "0.0.0"
uid ""

"@kbn/observability-ai-common@link:x-pack/solutions/observability/packages/observability_ai/observability_ai_common":
"@kbn/observability-ai-common@link:x-pack/solutions/observability/packages/observability-ai/observability-ai-common":
version "0.0.0"
uid ""

"@kbn/observability-ai-server@link:x-pack/solutions/observability/packages/observability_ai/observability_ai_server":
"@kbn/observability-ai-server@link:x-pack/solutions/observability/packages/observability-ai/observability-ai-server":
version "0.0.0"
uid ""

Expand Down

0 comments on commit 299a91c

Please sign in to comment.