Skip to content

Commit

Permalink
SKA: Fix kebab-case issues in observability-ui packages (elastic#211248)
Browse files Browse the repository at this point in the history
## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 3 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/observability-utils-browser` |
`x-pack/solutions/observability/packages/utils-browser` |
| `@kbn/observability-utils-common` |
`x-pack/solutions/observability/packages/utils-common` |
| `@kbn/observability-utils-server` |
`x-pack/solutions/observability/packages/utils-server` |


<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./tsconfig.base.json
./x-pack/solutions/observability/packages/utils-browser/jest.config.js
./x-pack/solutions/observability/packages/utils-common/jest.config.js
./x-pack/solutions/observability/packages/utils-server/jest.config.js
./x-pack/solutions/observability/packages/utils-server/jest.integration.config.js
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/solutions/observability/packages/utils-browser/jest.config.js:10
x-pack/solutions/observability/packages/utils-browser/tsconfig.json:2
x-pack/solutions/observability/packages/utils-common/jest.config.js:10
x-pack/solutions/observability/packages/utils-common/tsconfig.json:2
x-pack/solutions/observability/packages/utils-server/jest.config.js:10
x-pack/solutions/observability/packages/utils-server/jest.integration.config.js:10
x-pack/solutions/observability/packages/utils-server/tsconfig.json:2
```

</details>
  • Loading branch information
gsoldevila authored Feb 14, 2025
1 parent 5436558 commit 239bd8d
Show file tree
Hide file tree
Showing 69 changed files with 19 additions and 23 deletions.
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -928,9 +928,9 @@ x-pack/solutions/observability/packages/kbn-streams-schema @elastic/streams-prog
x-pack/solutions/observability/packages/observability_ai/observability_ai_common @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/observability_ai/observability_ai_server @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/synthetics_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/utils_browser @elastic/observability-ui
x-pack/solutions/observability/packages/utils_common @elastic/observability-ui
x-pack/solutions/observability/packages/utils_server @elastic/observability-ui
x-pack/solutions/observability/packages/utils-browser @elastic/observability-ui
x-pack/solutions/observability/packages/utils-common @elastic/observability-ui
x-pack/solutions/observability/packages/utils-server @elastic/observability-ui
x-pack/solutions/observability/plugins/apm @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/apm_data_access @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/apm/ftr_e2e @elastic/obs-ux-infra_services-team
Expand Down
4 changes: 0 additions & 4 deletions docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -699,10 +699,6 @@ using the CURL scripts in the scripts folder.
|Exposes services to access logs data.
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/logs_explorer/README.md[logsExplorer]
|This plugin is home to the <LogsExplorer /> component and related types. It implements several of the underlying concepts that the Observability Logs Explorer app builds upon.
|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/logs_shared/README.md[logsShared]
|Exposes the shared components and APIs to access and visualize logs.
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -709,9 +709,9 @@
"@kbn/observability-onboarding-plugin": "link:x-pack/solutions/observability/plugins/observability_onboarding",
"@kbn/observability-plugin": "link:x-pack/solutions/observability/plugins/observability",
"@kbn/observability-shared-plugin": "link:x-pack/solutions/observability/plugins/observability_shared",
"@kbn/observability-utils-browser": "link:x-pack/solutions/observability/packages/utils_browser",
"@kbn/observability-utils-common": "link:x-pack/solutions/observability/packages/utils_common",
"@kbn/observability-utils-server": "link:x-pack/solutions/observability/packages/utils_server",
"@kbn/observability-utils-browser": "link:x-pack/solutions/observability/packages/utils-browser",
"@kbn/observability-utils-common": "link:x-pack/solutions/observability/packages/utils-common",
"@kbn/observability-utils-server": "link:x-pack/solutions/observability/packages/utils-server",
"@kbn/oidc-provider-plugin": "link:x-pack/test/security_api_integration/plugins/oidc_provider",
"@kbn/open-telemetry-instrumented-plugin": "link:test/common/plugins/otel_metrics",
"@kbn/openapi-common": "link:src/platform/packages/shared/kbn-openapi-common",
Expand Down
12 changes: 6 additions & 6 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1362,12 +1362,12 @@
"@kbn/observability-shared-plugin/*": ["x-pack/solutions/observability/plugins/observability_shared/*"],
"@kbn/observability-synthetics-test-data": ["x-pack/solutions/observability/packages/synthetics_test_data"],
"@kbn/observability-synthetics-test-data/*": ["x-pack/solutions/observability/packages/synthetics_test_data/*"],
"@kbn/observability-utils-browser": ["x-pack/solutions/observability/packages/utils_browser"],
"@kbn/observability-utils-browser/*": ["x-pack/solutions/observability/packages/utils_browser/*"],
"@kbn/observability-utils-common": ["x-pack/solutions/observability/packages/utils_common"],
"@kbn/observability-utils-common/*": ["x-pack/solutions/observability/packages/utils_common/*"],
"@kbn/observability-utils-server": ["x-pack/solutions/observability/packages/utils_server"],
"@kbn/observability-utils-server/*": ["x-pack/solutions/observability/packages/utils_server/*"],
"@kbn/observability-utils-browser": ["x-pack/solutions/observability/packages/utils-browser"],
"@kbn/observability-utils-browser/*": ["x-pack/solutions/observability/packages/utils-browser/*"],
"@kbn/observability-utils-common": ["x-pack/solutions/observability/packages/utils-common"],
"@kbn/observability-utils-common/*": ["x-pack/solutions/observability/packages/utils-common/*"],
"@kbn/observability-utils-server": ["x-pack/solutions/observability/packages/utils-server"],
"@kbn/observability-utils-server/*": ["x-pack/solutions/observability/packages/utils-server/*"],
"@kbn/oidc-provider-plugin": ["x-pack/test/security_api_integration/plugins/oidc_provider"],
"@kbn/oidc-provider-plugin/*": ["x-pack/test/security_api_integration/plugins/oidc_provider/*"],
"@kbn/open-telemetry-instrumented-plugin": ["test/common/plugins/otel_metrics"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils_browser'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils-browser'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils_common'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils-common'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils_server'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils-server'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test/jest_integration',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils_server'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils-server'],
};
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6593,15 +6593,15 @@
version "0.0.0"
uid ""

"@kbn/observability-utils-browser@link:x-pack/solutions/observability/packages/utils_browser":
"@kbn/observability-utils-browser@link:x-pack/solutions/observability/packages/utils-browser":
version "0.0.0"
uid ""

"@kbn/observability-utils-common@link:x-pack/solutions/observability/packages/utils_common":
"@kbn/observability-utils-common@link:x-pack/solutions/observability/packages/utils-common":
version "0.0.0"
uid ""

"@kbn/observability-utils-server@link:x-pack/solutions/observability/packages/utils_server":
"@kbn/observability-utils-server@link:x-pack/solutions/observability/packages/utils-server":
version "0.0.0"
uid ""

Expand Down

0 comments on commit 239bd8d

Please sign in to comment.