Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS LLVM only requires -L for libzstd #1056

Merged
merged 1 commit into from
Nov 4, 2024
Merged

MacOS LLVM only requires -L for libzstd #1056

merged 1 commit into from
Nov 4, 2024

Conversation

nickg
Copy link
Owner

@nickg nickg commented Nov 4, 2024

Another attempt at fixing #1043.

Issue #1043

Co-authored-by: Jonathan Eisch <jeisch@users.noreply.github.com>
@jeisch
Copy link
Contributor

jeisch commented Nov 4, 2024

configure output looks good, no warnings and the arguments look as expected:

configure:10371: checking for LLVM (engine passes ipo linker native)
configure:10394: g++ -std=gnu++11 -o conftest -g -O2 -I/opt/local/libexec/llvm-16/include -std=c++17 -stdlib=libc++ -fno-exceptions -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -L/opt/local/libexec/llvm-16/lib -Wl,-search_paths_first -Wl,-headerpad_max_install_names -L/opt/local/lib conftest.cpp -lLLVMX86TargetMCA -lLLVMMCA -lLLVMX86Disassembler -lLLVMX86AsmParser -lLLVMX86CodeGen -lLLVMCFGuard -lLLVMGlobalISel -lLLVMX86Desc -lLLVMX86Info -lLLVMMCDisassembler -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMPasses -lLLVMIRPrinter -lLLVMCoroutines -lLLVMipo -lLLVMInstrumentation -lLLVMVectorize -lLLVMLinker -lLLVMFrontendOpenMP -lLLVMInterpreter -lLLVMExecutionEngine -lLLVMRuntimeDyld -lLLVMOrcTargetProcess -lLLVMOrcShared -lLLVMCodeGen -lLLVMTarget -lLLVMScalarOpts -lLLVMInstCombine -lLLVMAggressiveInstCombine -lLLVMObjCARCOpts -lLLVMTransformUtils -lLLVMBitWriter -lLLVMAnalysis -lLLVMProfileData -lLLVMSymbolize -lLLVMDebugInfoPDB -lLLVMDebugInfoMSF -lLLVMDebugInfoDWARF -lLLVMObject -lLLVMTextAPI -lLLVMMCParser -lLLVMIRReader -lLLVMAsmParser -lLLVMMC -lLLVMDebugInfoCodeView -lLLVMBitReader -lLLVMCore -lLLVMRemarks -lLLVMBitstreamReader -lLLVMBinaryFormat -lLLVMTargetParser -lLLVMSupport -lLLVMDemangle -lm -lz -lzstd -lcurses -lxml2 >&5
configure:10394: $? = 0
configure:10411: result: yes

@nickg
Copy link
Owner Author

nickg commented Nov 4, 2024

Great, thanks for testing.

@nickg nickg merged commit 15a61d7 into master Nov 4, 2024
23 of 24 checks passed
@nickg nickg deleted the libs-only-zstd branch February 2, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants