Improve safety and idiomaticity of API #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix memory leaks due to NanoSVG memory never getting freed. - Remove unwrap() usage outside tests, propagate errors to the caller. - Add a Units enum to safely represent the allowed values for the units parameter. - Expose methods to get SVG image width and height.
The C library doesn't handle such paths correctly (which is unreasonably hard to do in C/C++) so read the SVG file in Rust and pass its content to NanoSVG for parsing.
|
I've been meaning to make changes along these lines for a while (exposing width/height safely, better error handling) but I've been a bit busy, so thanks very much! I also wasn't aware of the memory leak, so thanks for finding and dealing with that. 👍 I'll try to publish a new version later today. |
|
I've published a new version (0.4.0) which includes your changes. Thanks again! |
|
That was fast, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for writing and publishing this library, I'm using it as part of an SVG -> ICO conversion. I've made a few improvements to the API:
parameter.
I initially only wanted the width and height access, but the memory leaks and unwrap() usage were pretty serious issues, and representing a fixed set of units values using an enum is more ergonomic than letting the user pass in any nonsense, so I stuck that in too.