Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HypersimDataset is missing #1

Closed
brotherofken opened this issue May 29, 2023 · 3 comments
Closed

HypersimDataset is missing #1

brotherofken opened this issue May 29, 2023 · 3 comments

Comments

@brotherofken
Copy link

Hi there!

I wanted to express my gratitude for making your research results publicly available and for releasing the source code.

While digging through the code base, I noticed that the implementation of HypersimDataset is missing but mentioned in the dataset_utils.py. I wanted to confirm whether this omission is intentional or if it occurred inadvertently during the process of making the code publicly available.

Best regards,
Rasim.

@mohammed-amr
Copy link
Collaborator

mohammed-amr commented May 30, 2023

Hello Rasim,

We're planning on releasing a HyperSim dataset class soon. Hang tight!

Mohamed

@brotherofken
Copy link
Author

brotherofken commented May 31, 2023

That will be extremely helpful!

Right now I'm working on Hypersim converter by myself and have encountered a few issues which have to be adressed carefully.

  1. Firstly, the depth maps seem to contain distance to the camera center instead of the actual depth.
    ground truth depth is actually distance apple/ml-hypersim#9
  2. Secondly, there are a few scenes with corrupted frames, which need to be excluded.
    Broken Scenes apple/ml-hypersim#22 (comment) which have to be excluded.
  3. Per scene intrincics must be used as prescribed here: https://github.com/apple/ml-hypersim/tree/main/contrib/mikeroberts3000
    upd. actually one has to reproject tilt-shifted images to bring intrinsics matrix to "standart" form.
  4. Not an issue, but tonemapping needs to be applied.
    https://github.com/apple/ml-hypersim/blob/main/code/python/tools/scene_generate_images_tonemap.py#L76

If you have a spare minute, could you please let me know if there are any other important details that I might be missing?

@qureshizawar
Copy link
Collaborator

Hi, sorry for the delay! We have just merged the Hypersim code, please check the README! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants