-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Scenes #22
Comments
Hi! Great questions. You're correct that In our computational pipeline, we assume that all artist-created cameras frame the scene in a meaningful way, and we use these artist-created cameras as a form of weak supervision to help us figure out how to generate more good views of each scene. But our assumption isn't always correct. Some artist-created cameras do not frame the scene in a meaningful way, e.g., While we're on the subject of You are also correct that |
That makes sense. Thanks for the explanation. Regarding the person label: You're right, this images has no person label, it only contains As of I've also took a look on the depth distribution after correcting it with the code from #9 : My explanation for the large spikes in val and test split are scenes, where the camera faces a wall perpendicular to it. Do you think this could be a sign for more broken scenes? |
I agree that Unfortunately I don't have a list of scenes affected by this texture rendering issue, but I know there are at most two or three such scenes. You'll be able to find the others by looking at the first image for each scene. There are only 461 scenes, so you won't need to do too much manual inspection. Those depth distributions look reasonable to me. Your interpretation of the spikes also sounds reasonable. There must be occasional frames where the camera is exactly aligned with a wall. I'm sure this phenomenon occasionally happens in the training set too, but perhaps it's less noticeable in your plots because the training set is bigger. I think this phenomenon can arise naturally when an artist-placed camera happens to be axis-aligned, and the walls in the scene also happen to be axis-aligned. And it is always possible (but unlikely) that one of our randomly generated views aligns perfectly with a wall. So this phenomenon is not necessarily indicative of a broken scene or camera trajectory or frame. That being said, it seems plausible to me that a perfectly axis-aligned camera is more likely to have been accidentally spawned by the artist, and less likely to have been carefully placed by the artist to frame the scene in a particular way. Therefore, when a camera is perfectly axis-aligned, perhaps it is a hint that the camera does not convey artistic intent. Of course, this reasoning only holds if the walls in the scene are also axis-aligned, but they usually are. |
My simple search found another pitch black scene in the training split: Thats true, I completely forgot that there are other tasks apart from the ones I'm working on 😅 That's a good explanation. |
Good catch! So the pitch black camera trajectories we've found so far are as follows:
While you were searching for pitch black camera trajectories, I manually inspected the scenes to look for that texture rendering problem. The scenes I found with the texture rendering problem are as follows:
I'll update these lists if we find any more. Thanks for helping to dig into these issues 😄 |
We've found more broken scenes. This time with black segmentation images or depths.
|
Good catch, thank you! |
I've noticed that there are scenes with pixels belonging to the class person. I took a closer look to theses scenes and discovered some broken renderings.
ai_004_009/images/scene_cam_01_final_preview
contains completely broken images. Seems like there is a light missing in that scene. But even the textures don't make any sense. This scene confuses even me, as a human. 😆frame.0001.diffuse_reflectance.jpg
frame.0001.tonemap.jpg
ai_038_007/images/scene_cam_00_final_preview
is missing textures completely. The floating rectangles 👻 are labeled as persons.frame.0014.tonemap.jpg
frame.0014.semantic.png
These are the first scenes I looked into. Both of them are included in the train split and are detrimental for training in my opinion.
Are you aware of such issues? How many more broken scenes could there be?
Despite this, thanks for your work.
The text was updated successfully, but these errors were encountered: