Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize GitHub actions workflow for code quality and security #25

Merged

Conversation

niStee
Copy link
Owner

@niStee niStee commented Jul 28, 2024

What does this PR do

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

niStee added 13 commits June 12, 2024 23:31
…e checkout step from shared-setup job to reduce duplication - Add caching for Rust toolchain to improve build times - These changes should improve the overall efficiency and performance of the workflow without compromising the code quality and security checks

This pull request optimizes the existing GitHub Actions workflow for code quality and security checks. The key changes include:

1. Reusing the checkout step from the `shared-setup` job in both the `devskim` and `rust-clippy` jobs to reduce duplication.
2. Adding caching for the Rust toolchain in the `rust-clippy` job to speed up the installation process.

These changes should help improve the overall efficiency and performance of the workflow, while maintaining the same level of code quality and security checks.
…stems

The GitHub Actions workflow has been updated to support multiple operating systems. This change allows the workflow to run on Ubuntu, macOS, and Windows. The matrix strategy has been added to specify the different operating systems. This optimization improves code quality and security.
…t operating system, as it is only supported on Linux
…f-fmt are already installed before installing them
…f-fmt are already installed before installing them
…f-fmt are already installed before installing them
…-fmt without checking if they are already installed
The insert_startup_scripts function in the windows.rs file has been optimized to improve performance and readability. The unnecessary conversion of the path variable to a Path object has been removed, resulting in more efficient code execution. This change enhances the overall functionality of the function and ensures smoother operation on Windows systems.
Adding OSV Scanner
@niStee niStee merged commit 008b136 into main Jul 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant