Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10 #155

Merged
merged 14 commits into from
Jan 3, 2023
Merged

Add support for Python 3.10 #155

merged 14 commits into from
Jan 3, 2023

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Dec 7, 2022

What does this Pull Request accomplish?

Update PR pipeline to test with Python 3.10.

Upgrade pytest to support Python 3.10.

Enable in-project virtualenvs for ni-measurement-generator. By default, poetry creates virtualenvs in %USERPROFILE%\AppData\....

Why should this Pull Request be merged?

Allow customers to use Python 3.10.

Fixes #153

What testing has been done?

Ran pytest locally.

.github/workflows/PR.yml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@bkeryan
Copy link
Collaborator Author

bkeryan commented Dec 7, 2022

FYI, this PR is not urgent.

@bkeryan bkeryan requested review from tkrebes and mshafer-NI December 7, 2022 23:49
ni_measurement_generator/poetry.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
.github/workflows/PR.yml Outdated Show resolved Hide resolved
@bkeryan
Copy link
Collaborator Author

bkeryan commented Dec 9, 2022

Now that we're working around the issue with black 22.10.0 having the wrong architecture on macOS, we're running into problems with grpcio 1.51.1 having the wrong architecture on macOS.

 Command '['/Users/runner/work/measurement-services-python/measurement-services-python/.venv/bin/python', '-m', 'pip', 'install', '--disable-pip-version-check', '--prefix', '/Users/runner/work/measurement-services-python/measurement-services-python/.venv', '--no-deps', '/Users/runner/Library/Caches/pypoetry/artifacts/2b/90/2d/f5d7acf5ce32ce2a6d2ed0f274a7110c075d38f9589b1fe13edd464bd9/grpcio-1.51.1-cp310-cp310-macosx_12_0_x86_64.whl']' returned non-zero exit status 1.

I downloaded https://files.pythonhosted.org/packages/e9/a4/2ee6a755db094ead5c705e59c42c5d0232d183d768b01326d20d580cf89b/grpcio-1.51.1-cp310-cp310-macosx_12_0_x86_64.whl and extracted cygrpc.cpython-310-darwin.so, and it has the right architecture:

% file cygrpc.cpython-310-darwin.so 
cygrpc.cpython-310-darwin.so: Mach-O 64-bit bundle x86_64

The GitHub runner has macOS 12.6, and I assume the machine is x86_64 based on the previous problem.

@bkeryan bkeryan merged commit 38f2b33 into main Jan 3, 2023
@dixonjoel dixonjoel deleted the users/bkeryan/python-3.10 branch January 3, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Python 3.10 support in PR pipeline
4 participants