Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override non-recommended rules in the Angular configuration. #45

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Override non-recommended rules in the Angular configuration. #45

merged 2 commits into from
Sep 2, 2021

Conversation

TrevorKarjanis
Copy link
Collaborator

  • Override non-recommended rules in the Angular configuration.

Notes

  • All of the non-recommended rules are temporarily defined here so that their configurations can be seen.
  • The tests are currently failing, because they violate one of the non-recommended rules.
  • To alleviate the difficulty of navigating the source code among many comments, a review containing a comment per rule has already been started.
  • Once the evaluation is complete, I will merge our overrides and remove the rest.

Linted and tested

TrevorKarjanis
TrevorKarjanis commented Jun 16, 2021
View reviewed changes
Copy link
Collaborator Author

@TrevorKarjanis TrevorKarjanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a comment in the thread for rules you wish to discuss. Click "Load more..." to load hidden comments.

angular-template.js Outdated Show resolved Hide resolved
angular-template.js Outdated Show resolved Hide resolved
angular-template.js Outdated Show resolved Hide resolved
angular-template.js Outdated Show resolved Hide resolved
angular-template.js Outdated Show resolved Hide resolved
angular.js Show resolved Hide resolved
angular.js Outdated Show resolved Hide resolved
angular.js Show resolved Hide resolved
angular.js Show resolved Hide resolved
angular.js Outdated Show resolved Hide resolved
@TrevorKarjanis TrevorKarjanis marked this pull request as ready for review June 16, 2021 14:08
@rajsite rajsite marked this pull request as draft July 20, 2021 23:14
@TrevorKarjanis TrevorKarjanis force-pushed the angular-configuration branch from eabca14 to 475176b Compare July 28, 2021 19:57
@TrevorKarjanis TrevorKarjanis marked this pull request as ready for review August 26, 2021 14:28
jattasNI
jattasNI approved these changes Aug 27, 2021
View reviewed changes
Copy link
Collaborator

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my vote on @angular-eslint/sort-ngmodule-metadata-arrays so I'm OK to leave it turned off initially.

README.md Outdated Show resolved Hide resolved
@TrevorKarjanis TrevorKarjanis merged commit da4570a into ni:main Sep 2, 2021
@TrevorKarjanis TrevorKarjanis deleted the angular-configuration branch September 2, 2021 18:03
@jattasNI jattasNI mentioned this pull request Sep 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jattasNI jattasNI jattasNI approved these changes

@LukasKall LukasKall Awaiting requested review from LukasKall

@mure mure Awaiting requested review from mure

@rajsite rajsite Awaiting requested review from rajsite rajsite is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorKarjanis @mure @jattasNI