Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import and initialise error summary JS and set focusOnPageLoad to false #1886

Merged
merged 3 commits into from
May 23, 2023
Merged

Import and initialise error summary JS and set focusOnPageLoad to false #1886

merged 3 commits into from
May 23, 2023

Conversation

the-nathan-smith
Copy link
Contributor

@the-nathan-smith the-nathan-smith commented May 22, 2023 •
edited
Loading

Description

Import and initialise error summary JS and set focusOnPageLoad to false so that the Error Summary examples work as expected.

Related issue

Resolves NHSUK Frontend Issue #766.

Checklist

andymantell
andymantell suggested changes May 22, 2023
View reviewed changes
app/scripts/main.js Outdated Show resolved Hide resolved
andymantell
andymantell suggested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@andymantell andymantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline is failing with eslint errors. You can run these locally with npm run lint

This was referenced May 22, 2023
Closed
Closed
@the-nathan-smith the-nathan-smith merged commit e692020 into main May 23, 2023
@the-nathan-smith the-nathan-smith deleted the initialise-error-summary branch May 23, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymantell andymantell andymantell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-nathan-smith @andymantell