Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution links within context #1000 #1001 #1073

Merged
merged 10 commits into from
Mar 30, 2021

Conversation

Tosin-Balogun
Copy link
Contributor

@Tosin-Balogun Tosin-Balogun commented Mar 24, 2021

Description

This is a prototype based on improving the users access to our contribution process through the service manual website

We will use this pull request to review changes, updates et al

Related issue

#1000 #1001

Checklist

@Tosin-Balogun Tosin-Balogun self-assigned this Mar 24, 2021
@Tosin-Balogun
Copy link
Contributor Author

The conclusion was to see if we can repurpose the 'get in touch' partial to host the contextual links idea. We would need to restyle and rewrite it based on the evidence we have discovered

@davidhunter08 - The above is correct, yes?
@sarawilcox @nancyhalladay24
Screenshot 2021-03-23 at 17 14 48

@Tosin-Balogun Tosin-Balogun temporarily deployed to nhs-service-manual-design-test March 29, 2021 16:02 Inactive
app/views/includes/_contact-panel.njk Show resolved Hide resolved
@Tosin-Balogun Tosin-Balogun temporarily deployed to nhs-service-manual-design-test March 30, 2021 09:04 Inactive
@Tosin-Balogun Tosin-Balogun temporarily deployed to nhs-service-manual-design-test March 30, 2021 09:06 Inactive
@Tosin-Balogun Tosin-Balogun temporarily deployed to nhs-service-manual-design-test March 30, 2021 09:18 Inactive
Copy link
Contributor

@sarawilcox sarawilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tosin, could you please make this 2 sentences. It should read:

Before you start, you will need a GitHub account. It's an open forum where we collect feedback.

@Tosin-Balogun
Copy link
Contributor Author

Hi Tosin, could you please make this 2 sentences. It should read:

Before you start, you will need a GitHub account. It's an open forum where we collect feedback.

Done ✅

Copy link
Contributor

@sarawilcox sarawilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tosin.

@Tosin-Balogun Tosin-Balogun merged commit 59315eb into master Mar 30, 2021
@Tosin-Balogun
Copy link
Contributor Author

@DomBaker - this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants