Skip to content

Commit

Permalink
Merge pull request #223 from nhsuk/move-list-border-css
Browse files Browse the repository at this point in the history
Move list-border css to the correct file
  • Loading branch information
DomBaker authored Dec 8, 2021
2 parents 44e21a9 + 49556fd commit ffcf912
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 9 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# NHS.UK prototype kit Changelog

## Unreleased
## 4.7.3 - 8 December 2021

:wrench: **Fixes**

- Install NHS.UK frontend v6.0.1
- Update Health A-Z with new Nav A-Z
- Add list-border css to `_list-border.scss`
- Add support for Node 16.x

Node 16.x recently became the long term supported version of Nodejs. The `gulp-sass` dependency had a peer dependency pinned to specific version `node-sass` that doesn't work on Node 16.x. Node 16.x support got added to `node-sass` in `6.0.0` and above
Expand Down
8 changes: 8 additions & 0 deletions app/assets/sass/components/_list-border.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// ==========================================================================
// COMPONENTS / #LIST-BORDER
// ==========================================================================

.nhsuk-list--border li {
border-bottom: 1px solid $color_nhsuk-grey-4;
padding: 8px 0 16px;
}
6 changes: 1 addition & 5 deletions app/assets/sass/main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,10 @@
@import 'node_modules/nhsuk-frontend/packages/nhsuk';

// Components that are not in the NHS.UK frontend library
@import 'components/list-border';
@import 'components/related-nav';

///////////////////////////////////////////
// Add your custom CSS/Sass styles below...
///////////////////////////////////////////

.nhsuk-list--border li {
border-bottom: 1px solid $color_nhsuk-grey-4;
padding: 8px 0 16px;
}

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nhsuk-prototype-kit",
"version": "4.7.2",
"version": "4.7.3",
"description": "Rapidly create HTML prototypes of NHS websites and services.",
"main": "app.js",
"scripts": {
Expand Down

0 comments on commit ffcf912

Please sign in to comment.