-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refs #384] Create summary list component from GOV.UK #404
Conversation
3654bd3
to
330c7ea
Compare
@davidhunter08 would you be able to have a look at the design (spacing etc) and let me know if you're happy with it. @GrilloPress if you want to have a look too and feedback anything 👍 |
330c7ea
to
2bd48aa
Compare
Summary list component styles, markup, macro and documentation taken from the GOV.UK Frontend.
2bd48aa
to
0d0f333
Compare
@AdamChrimes - Design (spacing etc.) looks ok. |
Thanks @davidhunter08, @mcheung-nhs please could you have a look when you are back. 🌤 |
Looks good generally. Big fan of the links going to the left-hand margin on mobile. Two thoughts:
Just working through some issues with GDS about this. Technically it may not be valid HTML to wrap the Axe interprets the rule as a strict I'm interpreting https://www.w3.org/TR/html5/grouping-content.html#the-dl-element as meaning that we can have |
Dave House from GDS confirmed my interpretation of the HTML spec. From GDS point of view. So wrapping Something to be aware of. |
Related work in Axe: dequelabs/axe-core#1284 (unreleased I think) |
Correcting the heading structure and adding separators.
…uk-frontend into feature/summary-list-component
I would also interpret the W3 specs mentioned that a Looking at further discussions with the axe-core library (dequelabs/axe-core#262) it seems there are no issues from a screen reader point of view. Therefore I'm happy for this to be merged and we'll have to put any exceptions if/when we implement axe in our CI. |
Description
Summary list component styles, markup, macro and documentation taken
from the GOV.UK Frontend.
To do