Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove handlebars #56

Merged
merged 9 commits into from
Dec 19, 2019
Merged

refactor: remove handlebars #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f3efd8d
refactor: apply tui-code-snippet@2
heenakwag Dec 3, 2019
63f4450
refactor: apply template of code-snippet
heenakwag Dec 5, 2019
2843877
chore: apply code review
heenakwag Dec 9, 2019
1dd3b1a
chore: apply code review
heenakwag Dec 10, 2019
cba4db6
chore: apply code review
heenakwag Dec 9, 2019
8caed42
chore: apply tui-code-snippet@2.2.0
heenakwag Dec 12, 2019
0e3410a
chore: set webpack optimization
heenakwag Dec 12, 2019
d94f4c1
chore: apply code review
heenakwag Dec 19, 2019
cce8732
chore: update dependencies
heenakwag Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ var options = {
var instance = new DatePicker(container, options);
```

Or, include [`tui-code-snippet`](https://github.com/nhn/tui.code-snippet)(**v1.5.0** or **later**) and then immediately write the options as follows:
Or, include [`tui-code-snippet`](https://github.com/nhn/tui.code-snippet)(**v2.2.0** or **later**) and then immediately write the options as follows:

```js
tui.usageStatistics = false;
Expand Down Expand Up @@ -121,8 +121,9 @@ tui.date-picker/
├─ latest
│ ├─ tui-date-picker.css
│ ├─ tui-date-picker.js
│ ├─ tui-date-picker.min.js
├─ v3.0.0/
│ ├─ tui-date-picker.min.css
│ └─ tui-date-picker.min.js
├─ v4.0.0/
│ ├─ ...
```

Expand Down Expand Up @@ -186,9 +187,8 @@ For more information about the API, please see [here](http://nhn.github.io/tui.d


## 🔩 Dependency
* [tui-code-snippet](https://github.com/nhn/tui.code-snippet) >=1.5.0
* [tui-dom](https://github.com/nhn/tui.dom) >=3.0.0
* [tui-time-picker](https://github.com/nhn/tui.time-picker) >=2.0.0
* [tui-code-snippet](https://github.com/nhn/tui.code-snippet) >= 2.2.0
* [tui-time-picker](https://github.com/nhn/tui.time-picker) >= 2.0.3


## 🌏 Browser Support
Expand Down
5 changes: 2 additions & 3 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
"package-lock.json"
],
"dependencies": {
"tui-code-snippet": "^1.5.0",
"tui-dom": "^3.0.0",
"tui-time-picker": "^2.0.0"
"tui-code-snippet": "^2.2.0",
"tui-time-picker": "^2.0.3"
}
}
9 changes: 3 additions & 6 deletions docs/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,18 @@ var instance = new tui.DatePicker(container, {
```

## Load dependency files
* Script - [tui-code-snippet](https://github.com/nhn/tui.code-snippet) 1.5.0 or later
* Script - [tui-dom](https://github.com/nhn/tui.dom) 3.0.0 or later
> If your project should support IE8, please use `tui-dom.js`, not `tui-dom.min.js`.
* Script - [tui-time-picker](https://github.com/nhn/tui.time-picker) 2.0.0 or later
* Script - [tui-time-picker](https://github.com/nhn/tui.time-picker) 2.0.3 or later

```html
<html>
<head>
....
<link href="tui-time-picker.css" rel="stylesheet">
<link href="tui-date-picker.css" rel="stylesheet">
</head>
<body>
....
<script type="text/javascript" src="tui-code-snippet.js"></script>
<script type="text/javascript" src="tui-dom.min.js"></script>
<script type="text/javascript" src="tui-time-picker.js"></script>
<script type="text/javascript" src="tui-date-picker.js"></script>
....
</body>
Expand Down
3 changes: 0 additions & 3 deletions examples/example01-basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
</div>
<div id="wrapper" style="margin-top: -1px;"></div>
</div>

<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script class="code-js">
var datepicker = new tui.DatePicker('#wrapper', {
Expand Down
3 changes: 0 additions & 3 deletions examples/example02-inline-style.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
</div>
<div id="wrapper" style="margin-top: -1px;"></div>
</div>

<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script class="code-js">
var datepicker = new tui.DatePicker('#wrapper', {
Expand Down
2 changes: 0 additions & 2 deletions examples/example03-selectable-ranges.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ <h3>Selectables</h3>
</div>
<div id="wrapper" style="margin-top: -1px;"></div>
</div>
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script class="code-js">
var datepicker = new tui.DatePicker('#wrapper', {
Expand Down
10 changes: 2 additions & 8 deletions examples/example04-having-timepicker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>4. Having TimePicker</title>
<link rel="stylesheet" type="text/css" href="./css/tui-example-style.css" />
<link
href="https://uicdn.toast.com/tui.time-picker/v2.0.2/tui-time-picker.css"
href="https://uicdn.toast.com/tui.time-picker/v2.0.3/tui-time-picker.css"
rel="stylesheet"
/>
<link href="../dist/tui-date-picker.css" rel="stylesheet" />
Expand Down Expand Up @@ -39,15 +39,9 @@
</tbody>
</table>
</div>

<script
type="text/javascript"
src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"
></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script
type="text/javascript"
src="https://uicdn.toast.com/tui.time-picker/v2.0.2/tui-time-picker.js"
src="https://uicdn.toast.com/tui.time-picker/v2.0.3/tui-time-picker.js"
></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script class="code-js">
Expand Down
3 changes: 0 additions & 3 deletions examples/example05-picking-month.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@
</tbody>
</table>
</div>

<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script type="text/javascript" class="code-js">
tui.DatePicker.localeTexts['Chinese character'] = {
Expand Down
3 changes: 0 additions & 3 deletions examples/example06-picking-year.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@
</tbody>
</table>
</div>

<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script type="text/javascript" class="code-js">
tui.DatePicker.localeTexts['Chinese character'] = {
Expand Down
3 changes: 0 additions & 3 deletions examples/example07-calendar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
</tbody>
</table>
</div>

heenakwag marked this conversation as resolved.
Show resolved Hide resolved
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script type="text/javascript" class="code-js">
var DatePicker = tui.DatePicker;
Expand Down
2 changes: 0 additions & 2 deletions examples/example08-daterangepicker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
<div id="endpicker-container" style="margin-left: -1px;"></div>
</div>
</div>
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script class="code-js">
var today = new Date();
Expand Down
2 changes: 0 additions & 2 deletions examples/example09-changing-type.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
<input type="radio" id="year" name="datePickerType" value="year">
<label for="year">year</label>
</div>
<script type="text/javascript" src="https://uicdn.toast.com/tui.code-snippet/v1.5.0/tui-code-snippet.js"></script>
<script type="text/javascript" src="https://uicdn.toast.com/tui.dom/v3.0.0/tui-dom.js"></script>
<script type="text/javascript" src="../dist/tui-date-picker.js"></script>
<script class="code-js">
var util = {
Expand Down
7 changes: 1 addition & 6 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,10 @@ module.exports = function(config) {
},
{
test: /\.js$/,
exclude: /(bower_components|node_modules)/,
exclude: /(bower_components|node_modules|dist)/,
loader: 'eslint-loader',
enforce: 'pre'
},
{
test: /\.hbs$/,
exclude: /(node_modules)/,
loader: 'handlebars-loader'
},
{
test: /\.css/,
loader: 'style-loader!css'
Expand Down
Loading