Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: calculate endRowIndex properly when week.hourStart/hourEnd option is applied (fix #1238) #1242

Merged
merged 3 commits into from
Aug 9, 2022
Merged

fix: calculate endRowIndex properly when week.hourStart/hourEnd option is applied (fix #1238) #1242

merged 3 commits into from
Aug 9, 2022

Conversation

adhrinae
Copy link
Contributor

@adhrinae adhrinae commented Aug 8, 2022

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

This PR resolves #1238 and #1239.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@adhrinae adhrinae requested review from heenakwag and lja1018 August 8, 2022 03:53
@adhrinae adhrinae changed the title fix: calculate endRowIndex when week.hourStart/hourEnd option is applied (fix #1238) fix: calculate endRowIndex properly when week.hourStart/hourEnd option is applied (fix #1238) Aug 8, 2022
heenakwag
heenakwag approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@heenakwag heenakwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

lja1018
lja1018 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@adhrinae adhrinae merged commit b5a0274 into main Aug 9, 2022
@adhrinae adhrinae deleted the fix/horizontal-grid-selection-with-options branch August 9, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lja1018 lja1018 lja1018 approved these changes

@heenakwag heenakwag heenakwag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using hourStart, hourEnd dragging across days does not work properly
3 participants
@adhrinae @heenakwag @lja1018