Target netstandard2.0 and NH 5.1.0 #391
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "projects": [ "src" ], | ||
| "sdk": { | ||
| "version": "2.1.4" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;net461</TargetFrameworks> | ||
| <NoWarn>1591</NoWarn> | ||
| <PlatformTarget>AnyCpu</PlatformTarget> | ||
| <OutputType>Library</OutputType> | ||
|
|
@@ -13,22 +13,26 @@ | |
| <Description>FluentNHibernate</Description> | ||
| </PropertyGroup> | ||
|
|
||
|
|
||
| <PropertyGroup> | ||
| <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet> | ||
| </PropertyGroup> | ||
|
|
||
| <Import Project="$(MSBuildThisFileDirectory)..\Shared.msbuild" /> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net461'"> | ||
| <PackageReference Include="NHibernate" Version="5.0.3" /> | ||
| <Reference Include="System.configuration" /> | ||
| <Reference Include="System.ServiceModel" /> | ||
| <Reference Include="System.Transactions" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
| <PackageReference Include="NHibernate" Version="5.1.0" /> | ||
| <PackageReference Include="System.Data.SqlClient" Version="4.4.3" /> | ||
|
There was a problem hiding this comment. We need System.Data.SqlClient? There was a problem hiding this comment. Yes, it seems it is needed for the MsSqlConnectionStringBuilder There was a problem hiding this comment. We could create our own implementation of the builder like the MySqlConnectionStringBuilder. Because we use the connectionString only, and have no interaction with the sqlconnectionstringbuilder for the user. There was a problem hiding this comment. The use of a package that the developer does not have a interaction with it is not a good implementation. (the user only pass the connectionString as string) There was a problem hiding this comment. @danilobreda @mgoodfellow Seem right. You can take care of this in another PR when we finish this one? There was a problem hiding this comment. @jrgcubano yes i can, i will wait for this release. |
||
| </ItemGroup> | ||
|
|
||
|
|
||
| <ItemGroup> | ||
| <Compile Include="..\CommonAssemblyInfo.cs"> | ||
| <Link>Properties\CommonAssemblyInfo.cs</Link> | ||
|
|
@@ -37,4 +41,5 @@ | |
| <Link>FluentKey.snk</Link> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 5.1.0 as well now? Because all the tests are based on 5.1.0 so we should target this entire release to that? 5.1.0 does support net461 as well