test(integration): angular 5.2 + typescript 2.7 #852

splincode · 2019-02-18T18:48:14Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

#847

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

# Conflicts: # integrations/hello-world-ng5/.angular-cli.json # integrations/hello-world-ng5/package.json # integrations/hello-world-ng5/src/app/app.module.ts

markwhitfeld

Great!

markwhitfeld · 2019-02-18T18:57:31Z

Just a note that, as discussed, Angular 5.2 does officially not support TS 2.7, but there is an existing issue #357 that has been around for a while that points out why we upgraded to TS2.7 as a workaround (at least for now).
Also, upgrading rxjs with the compat lib fixed issue #270 also found in this integration app.

markwhitfeld · 2019-02-19T19:51:29Z

@splincode I recommend just adding a 'pre*' npm script step for the specific integration build task that copies the @ngxs folder into the node_modules folder of the ng 5 integration app.
This worked for me and allowed me to identify and fix those issues.

splincode · 2019-02-22T22:21:52Z

We can't support TypeScript 2.7, because my build does not work at all for the new version of NGXS (3.4.0-dev): ReactiveX/rxjs#4512

I propose to make an announcement where we indicate the versions that we can minimally support.

Minimal TypeScript - 2.8
Minimal Angular - 5.2
Minimal RxJS - 6.2, or (rxjs - 5.6.0-forward-compat.4, rxjs-compat - 6.2.2)

# Conflicts: # packages/hmr-plugin/src/public_api.ts # packages/hmr-plugin/src/symbols.ts # yarn.lock

splincode · 2019-02-22T23:24:45Z

integration test is ready

markwhitfeld · 2019-02-23T04:24:04Z

packages/hmr-plugin/src/public_api.ts

+  NgxsHmrOptions,
+  NgxsHmrSnapshot,
+  WebpackModule,
+  BootstrapModuleFn


Why have WebpackModule and BootstrapModuleFn been added to the exports?
Was something not working? It works fine in my app without this.

no, it works without, I just wanted to use the types in the example, the user may also want this

markwhitfeld · 2019-02-23T04:25:15Z

integrations/hello-world-ng5/package.json

@@ -50,6 +42,6 @@
    "protractor": "5.1.2",
    "ts-node": "4.1.0",
    "tslint": "5.9.1",
-    "typescript": "2.7.1"
+    "typescript": "2.8.1"


What was the reason for this version bump?
I had it working with 2.7.1

ReactiveX/rxjs#4512 (comment)

I did the same thing, copied the directories, it did not work, I did it through the paths, but it did not work there

markwhitfeld · 2019-02-25T07:26:53Z

Giving an error when I try to start this integration app:

splincode · 2019-02-25T07:44:52Z

@markwhitfeld we need fix it

splincode · 2019-02-25T07:45:25Z

I think we need to add unit tests for this integration test.

markwhitfeld · 2019-02-25T08:21:27Z

Ok, I got the router working. Fixed the issue above.
@splincode I agree about some unit tests. Could you add some. I think just a basic AppComponent test that dispatches an action and then checks that it is rendered on the component would suffice.

markwhitfeld · 2019-02-25T08:23:06Z

One last issue I have picked up...
App starts and serves great, but when I made a change and HMR pushed the update then I get this error:

@splincode could you try to reproduce and see if there is a bug in HMR? ... maybe HMR doesn't support Angular 5?

markwhitfeld

HMR seems to not be working. See comment above.

markwhitfeld · 2019-02-26T10:20:42Z

@splincode will fix the hmr issue with NG5 in a separate PR.

splincode added 6 commits February 18, 2019 02:08

test(integration): angular 5.2 + typescript 2.5

836f282

chore: fix tsconfig.json

c5c1ee6

chore: remove unused files

53e421e

chore: remove unused tslint.json

22c3b2c

test(integration): angular 5.2 + typescript 2.7

b367d4d

Merge branch 'master' into integration-test

1287ffa

# Conflicts: # integrations/hello-world-ng5/.angular-cli.json # integrations/hello-world-ng5/package.json # integrations/hello-world-ng5/src/app/app.module.ts

splincode changed the title ~~Integration test~~ test(integration): angular 5.2 + typescript 2.7 Feb 18, 2019

markwhitfeld approved these changes Feb 18, 2019

View reviewed changes

splincode added 2 commits February 18, 2019 22:32

test(integration): angular 5.2 + typescript 2.7

4a4ab39

Merge branch 'master' into integration-test

2fc6da8

splincode changed the title ~~test(integration): angular 5.2 + typescript 2.7~~ test(integration): angular 5.2 + typescript 2.8 Feb 22, 2019

splincode added 3 commits February 23, 2019 02:11

fix(integration): only support 2.8+

59c3dfc

Merge branch 'master' into integration-test

6199d79

# Conflicts: # packages/hmr-plugin/src/public_api.ts # packages/hmr-plugin/src/symbols.ts # yarn.lock

chore: fix merge conflict

dffe4c5

splincode requested a review from markwhitfeld February 22, 2019 23:24

markwhitfeld reviewed Feb 23, 2019

View reviewed changes

splincode requested a review from markwhitfeld February 24, 2019 08:09

splincode mentioned this pull request Feb 24, 2019

Add integration test with Angular 5 + TypeScript 2.7 #847

Closed

markwhitfeld added 8 commits February 24, 2019 15:47

chore: change to used copied folder for @ngxs

8bff498

chore: add start script and add polyfills

c24e569

fix: downgrade to typescript 2.7 again

d3b0113

fix: router.module should be usable from angular 5

02d0a28

chore: add CircleCi config for ng5 integration test

6da442e

fix: test should work in MacOS too

5370634

fix: try again

dc7f824

fix: trying again again

74fda36

splincode changed the title ~~test(integration): angular 5.2 + typescript 2.8~~ test(integration): angular 5.2 + typescript 2.7 Feb 24, 2019

arturovt approved these changes Feb 24, 2019

View reviewed changes

markwhitfeld mentioned this pull request Feb 25, 2019

feat(store): upgrade to angular 7 #616

Merged

3 tasks

fix: the Router plugin should work in Angular 5

e9cc296

markwhitfeld requested changes Feb 25, 2019

View reviewed changes

markwhitfeld approved these changes Feb 26, 2019

View reviewed changes

markwhitfeld merged commit e6a6632 into master Feb 26, 2019

eranshmil deleted the integration-test branch March 1, 2019 11:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(integration): angular 5.2 + typescript 2.7 #852

test(integration): angular 5.2 + typescript 2.7 #852

splincode commented Feb 18, 2019 •

edited

Loading

markwhitfeld left a comment

markwhitfeld commented Feb 18, 2019 •

edited

Loading

markwhitfeld commented Feb 19, 2019

splincode commented Feb 22, 2019

splincode commented Feb 22, 2019

markwhitfeld Feb 23, 2019

splincode Feb 23, 2019

markwhitfeld Feb 23, 2019

splincode Feb 23, 2019

markwhitfeld commented Feb 25, 2019

splincode commented Feb 25, 2019

splincode commented Feb 25, 2019

markwhitfeld commented Feb 25, 2019

markwhitfeld commented Feb 25, 2019 •

edited

Loading

markwhitfeld left a comment

markwhitfeld commented Feb 26, 2019

test(integration): angular 5.2 + typescript 2.7 #852

test(integration): angular 5.2 + typescript 2.7 #852

Conversation

splincode commented Feb 18, 2019 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

markwhitfeld left a comment

Choose a reason for hiding this comment

markwhitfeld commented Feb 18, 2019 • edited Loading

markwhitfeld commented Feb 19, 2019

splincode commented Feb 22, 2019

splincode commented Feb 22, 2019

markwhitfeld Feb 23, 2019

Choose a reason for hiding this comment

splincode Feb 23, 2019

Choose a reason for hiding this comment

markwhitfeld Feb 23, 2019

Choose a reason for hiding this comment

splincode Feb 23, 2019

Choose a reason for hiding this comment

markwhitfeld commented Feb 25, 2019

splincode commented Feb 25, 2019

splincode commented Feb 25, 2019

markwhitfeld commented Feb 25, 2019

markwhitfeld commented Feb 25, 2019 • edited Loading

markwhitfeld left a comment

Choose a reason for hiding this comment

markwhitfeld commented Feb 26, 2019

splincode commented Feb 18, 2019 •

edited

Loading

markwhitfeld commented Feb 18, 2019 •

edited

Loading

markwhitfeld commented Feb 25, 2019 •

edited

Loading