Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): patch state bug #348

Merged
merged 1 commit into from
May 2, 2018
Merged

fix(store): patch state bug #348

merged 1 commit into from
May 2, 2018

Conversation

amcdnl
Copy link
Member

@amcdnl amcdnl commented May 2, 2018

Fixes patch state mutating the original state.

@amcdnl amcdnl self-assigned this May 2, 2018
@amcdnl amcdnl requested review from markwhitfeld and deebloo May 2, 2018 15:24
markwhitfeld
markwhitfeld approved these changes May 2, 2018
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. I would prefer some tests around this, but that can be in a subsequent PR ;-)

@amcdnl amcdnl merged commit 725132d into master May 2, 2018
@amcdnl amcdnl deleted the patch-state branch May 2, 2018 18:40
@markwhitfeld markwhitfeld mentioned this pull request Aug 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@deebloo deebloo Awaiting requested review from deebloo

Assignees

@amcdnl amcdnl

Labels
domain: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcdnl @markwhitfeld