fix: Better migration path from the ngrok kuberntes-ingress-controller to the ngrok-operator #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Attempts to provide a better migration path between the kubernetes-ingress-controller and the ngrok-operator. One of the problems identified is that it duplicates CRs in existing environments because the
k8s.ngrok.com/controller-nameandk8s.ngrok.com/controller-namespacelabels (that we b/c owner references are not allowed cross namespace) do not match what the new operator thinks it should.How
For the initial ngrok-operator release, include a migration on startup that will re-label the domains, httpsedges, and tunnels with the expected labels so that new objects are not created but are instead adopted.
Breaking Changes
No