Use unique context for endpoint poller reconcile actions #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jonstacks
approved these changes
Nov 7, 2024
| r.reconcileBoundEndpointAction(ctx, errGroup, toDelete, "delete", func(ctx context.Context, binding bindingsv1alpha1.BoundEndpoint) error { | ||
| return r.deleteBinding(ctx, binding) | ||
| r.reconcileBoundEndpointAction(reconcileActionCtx, errGroup, toDelete, "delete", func(reconcileActionCtx context.Context, binding bindingsv1alpha1.BoundEndpoint) error { | ||
| return r.deleteBinding(reconcileActionCtx, binding) | ||
| }) | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Question Do we need an errGroup.Wait() here or are we just using the errgroup to spawn all of them at the same time and relying on the context being canceled? If the latter, it might be clearer if we drop the errgroup and just use goroutines for concurrent processing.
There was a problem hiding this comment.
No I think you're right - I'm mixing up using errGroup and managing the ctx cancel myself. I'll clean this up.
4751bd3 to
9386161
Compare
9386161 to
eb22aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
Use a unique context so we can control the cancel rather than the ctrl manager.
How
Describe the solution
Breaking Changes
Are there any breaking changes in this PR?