Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GatewayClass to cachestore #376

Merged
merged 1 commit into from
May 16, 2024
Merged

Add GatewayClass to cachestore #376

merged 1 commit into from
May 16, 2024

Conversation

bobzilladev
Copy link
Contributor

Resolves:

2024-05-16T17:41:30Z ERROR cache-store-driver error updating object in create {"UpdateStoreHandlerFor": "", "object": {"name": "simple-gatewayclass"}, "error": "unsupported object type: *v1.GatewayClass"}

Also logs when a gateway does not have an https listener (so cannot be used).

@bobzilladev bobzilladev requested a review from a team as a code owner May 16, 2024 19:57
@github-actions github-actions bot added the area/controller Issues dealing with the controller label May 16, 2024
nikolay-ngrok
nikolay-ngrok approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@nikolay-ngrok nikolay-ngrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

OfTheDelmer
OfTheDelmer approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@OfTheDelmer OfTheDelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had a question about the store.go being updated, but it looks like this is related to some internal cache store changes not called by us.

internal/store/cachestores.go
Gateway cache.Store
HTTPRoute cache.Store
Gateway cache.Store
GatewayClass cache.Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bobzilladev bobzilladev merged commit ef27dd1 into main May 16, 2024
7 checks passed
@bobzilladev bobzilladev deleted the bob/cache branch May 16, 2024 20:10
@bobzilladev bobzilladev self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfTheDelmer OfTheDelmer OfTheDelmer approved these changes

@nikolay-ngrok nikolay-ngrok nikolay-ngrok approved these changes

@Abdiramen Abdiramen Awaiting requested review from Abdiramen

Assignees

@bobzilladev bobzilladev

Labels
area/controller Issues dealing with the controller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobzilladev @OfTheDelmer @nikolay-ngrok