-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules to traffic policy #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts a single traffic policy from the ingress annotation, and fails if more than one is provided. Co-authored-by: bobzilla <bob@ngrok.com>
Co-authored-by: bobzilla <bob@ngrok.com>
Using RawMessage invokes some special casing under the hood that aliasing interferes with the validation of the object specified to kubebuilder. Co-authored-by: bobzilla <bob@ngrok.com>
713a79c
to
ed4ba6a
Compare
bobzilladev
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm still, one comment
Refactors to remove the interleaved lines regarding policy json into a single method call.
bobzilladev
reviewed
May 1, 2024
OfTheDelmer
commented
May 1, 2024
Abdiramen
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/controller
Issues dealing with the controller
area/helm-chart
Issues dealing with the helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the https edge ingress route spec with either the annotated modset policy or the annotated traffic policy policy
How
GetModuleSetV1
path for the traffic policy CRDjson.RawMessage
because the alias ofRawMessage
causes issues with kubebuilder validation internallyValidation
ingress_trafficpolicy_crd_test.yml
2048.yml