Gateway spins up Ngrok CRDs #343
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Abdiramen and the rest of your teammates on |
ce63e7b to
0433734
Compare
47f2cf9 to
64e0b2c
Compare
d3d394d to
810522a
Compare
2c502b4 to
0ecef97
Compare
Agreed, we'll have to get to that after the first release! |
ea4f07d to
06b158b
Compare
| if filter.Path == nil { | ||
| from := ".*" //"^https?://[^/]+(:[0-9]*)?(/[^\\?]*)?(\\?.*)?$" | ||
| to := fmt.Sprintf("%s://%s%s$uri", scheme, hostname, port) | ||
| err := d.createUrlRedirectConfig(from, to, requestHeaders, filter.StatusCode, actions) |
There was a problem hiding this comment.
looks like you can just do
return d.createUrlRedirectConfig(from, to, requestHeaders, filter.StatusCode, actions)here 🤷
There was a problem hiding this comment.
I'll cut a new ticket to clean up the rest
| d.log.Error(err, "cannot convert request redirect filter to json", "HTTPRequestRedirectFilter", urlRedirectAction) | ||
| return err | ||
| } | ||
| actions.endpointActions = append( |
There was a problem hiding this comment.
be great if we hide this behind Add 🤷
There was a problem hiding this comment.
I'll cut a new ticket to clean up the rest
| case gatewayv1.HTTPRouteFilterExtensionRef: | ||
| return nil, errors.NewErrorNotFound(fmt.Sprintf("Unsupported filter HTTPRouteFilterType %v found", filter.Type)) | ||
| default: | ||
| return nil, errors.NewErrorNotFound(fmt.Sprintf("Unknown filter HTTPRouteFilterType %v found", filter.Type)) |
There was a problem hiding this comment.
errors.NewErrorNotFound doesn't seem quite appropriate here, wdyt?
There was a problem hiding this comment.
I'll cut a new ticket to add new errors
| } | ||
|
|
||
| if len(match.QueryParams) > 0 { | ||
| d.log.Error(fmt.Errorf("Unsupported match type"), "Unsupported match type", "HTTPQueryParamMatch", match.QueryParams) |
There was a problem hiding this comment.
should there return errors here? (and above)
There was a problem hiding this comment.
yes, agreed, it should throw an error here.
|
|
||
| for _, gtw := range gateways { | ||
| for _, listener := range gtw.Spec.Listeners { | ||
| if listener.Hostname == nil { |
There was a problem hiding this comment.
There was a problem hiding this comment.
good catch, i'll add all of these to a follow up ticket
What
DomainsCRDs spun up byGatewayHTTPSEdgesspun up byHTTPRouteattached to aGateway:HTTPSEdgeRoutecreated on anHTTPSEdgecorresponding to aHTTPRouteRuleHow
Gatewayinto cachestore, store, and driverHTTPRouteinto cachestore, store, and driverBreaking Changes
Nope, but the gateway currently just throws an error, and is prone to change!