Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase domain name in helm NOTES.txt #336

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

jonstacks
Copy link
Collaborator

Closes: #325

What

Lowercase the host in the ingress rule(s) provided by NOTES.txt after a helm install/upgrade.

How

Just pipe the random alpha num to the lower template function.

Validation

You can make this accessible via ngrok with the following manifest:
--------------------------------------------------------------------------------
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: test-app-1
  namespace: default
spec:
  ingressClassName: ngrok
  rules:
  - host: test-app-1-s3gmyzci.ngrok.app
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: test-app-1
            port:
              number: 80
--------------------------------------------------------------------------------
Applying this manifest will make the service "test-app-1"
available on the public internet at "https://test-app-1-s3gmyzci.ngrok.app/".

One example, taken from your cluster, is the Service:
   "test-app-1"

You can make this accessible via ngrok with the following manifest:
--------------------------------------------------------------------------------
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: test-app-1
  namespace: default
spec:
  ingressClassName: ngrok
  rules:
  - host: test-app-1-wussk2wn.ngrok.app
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: test-app-1
            port:
              number: 443
--------------------------------------------------------------------------------
Applying this manifest will make the service "test-app-1"
available on the public internet at "https://test-app-1-wussk2wn.ngrok.app/".

Once done, view your edges in the Dashboard https://dashboard.ngrok.com/cloud-edge/edges
Find the tunnels running in your cluster here https://dashboard.ngrok.com/tunnels/agents

If you have any questions or feedback, please join us in https://ngrok.com/slack and let us know!
deployment.apps/ngrok-ingress-controller-kubernetes-ingress-controller-manager restarted

Breaking Changes

No

@jonstacks jonstacks requested a review from a team as a code owner January 25, 2024 08:14
@github-actions github-actions bot added the area/helm-chart Issues dealing with the helm chart label Jan 25, 2024
@jonstacks jonstacks self-assigned this Jan 25, 2024
@jonstacks jonstacks merged commit bd407d5 into ngrok:main Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm-chart Issues dealing with the helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example ingress yaml should lowercase domain
2 participants