Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon to pull from helm http #333

Merged
merged 1 commit into from
Jan 10, 2024
Merged

update icon to pull from helm http #333

merged 1 commit into from
Jan 10, 2024

Conversation

bobzilladev
Copy link
Contributor

What

Fix the artifacthub.io icon for ngrok/kubernetes-ingress-controller. This updates the chart, so artifacthub should also pick up the verification file change (https://github.com/ngrok/kubernetes-ingress-controller/pull/332).

How

Updates icon to working link:
https://ngrok.github.io/kubernetes-ingress-controller/ngrok-favicon.svg

Breaking Changes

None

@bobzilladev bobzilladev requested a review from a team as a code owner January 9, 2024 15:35
@github-actions github-actions bot added area/helm-chart Issues dealing with the helm chart area/release Issues relating to releases labels Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

👋 Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

@bobzilladev bobzilladev requested a review from alex-bezek January 9, 2024 15:37
@bobzilladev bobzilladev self-assigned this Jan 9, 2024
@bobzilladev bobzilladev requested a review from Abdiramen January 10, 2024 19:18
@bobzilladev bobzilladev merged commit e21e6ae into main Jan 10, 2024
9 checks passed
@bobzilladev bobzilladev deleted the bob/icon branch January 10, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm-chart Issues dealing with the helm chart area/release Issues relating to releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants