Skip to content

Commit

Permalink
Update template to use the correctly cased values property for allowe…
Browse files Browse the repository at this point in the history
…d urls (#448)

## What

when attempting to install the controller with binding enabled (like by using `make deploy_with_bindings`) it errors on main

```
Error: UPGRADE FAILED: cannot patch "default-configuration" with kind BindingConfiguration: BindingConfiguration.bindings.k8s.ngrok.com "default-configuration" is invalid: spec.allowedURLs: Required value
make: *** [deploy_with_bindings] Error 1
```

## How
*Describe the solution*

The casing is just incorrect so it doesn't get the default value of `"*"` and instead is null
  • Loading branch information
hjkatz authored Oct 15, 2024
2 parents 9fc7e61 + d98fe19 commit 62056c3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion helm/ngrok-operator/templates/binding-configuration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
name: {{ .Values.bindings.name }}
description: {{ .Values.bindings.description }}
allowedURLs:
{{- toYaml .Values.bindings.allowedUrls | nindent 6 }}
{{- toYaml .Values.bindings.allowedURLs | nindent 6 }}
tlsSecretName: "default-tls"
region: {{ .Values.region }}
projectedMetadata:
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 62056c3

Please sign in to comment.